Skip to content

Commit 68551a2

Browse files
committed
chore: downgrade utopia-php/http to version 0.34.* and update related tests
1 parent 16edd2c commit 68551a2

File tree

4 files changed

+42
-70
lines changed

4 files changed

+42
-70
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"ext-json": "*",
2020
"ext-redis": "*",
2121
"utopia-php/servers": "0.3.*",
22-
"utopia-php/http": "1.2.*",
22+
"utopia-php/http": "0.34.*",
2323
"utopia-php/cli": "0.23.*",
2424
"utopia-php/queue": "0.16.*"
2525
},

composer.lock

Lines changed: 11 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/Platform/MockResponse.php

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,13 @@
66

77
class MockResponse extends Response
88
{
9-
public function end(string $content = null): void
9+
public function end(?string $content = null): void
1010
{
1111
if (! is_null($content)) {
1212
echo $content;
1313
}
1414
}
1515

16-
public function send(string $body = ''): void
17-
{
18-
$this->sent = true;
19-
$this->end($body);
20-
}
21-
22-
public function chunk(string $body = '', bool $end = false): void
23-
{
24-
if ($end) {
25-
$this->sent = true;
26-
}
27-
$this->write($body);
28-
if ($end) {
29-
$this->end();
30-
}
31-
}
32-
3316
public function write(string $content): bool
3417
{
3518
if (! is_null($content)) {
@@ -39,7 +22,7 @@ public function write(string $content): bool
3922
return true;
4023
}
4124

42-
protected function sendStatus(int $statusCode, string $reason): void
25+
protected function sendStatus(int $statusCode): void
4326
{
4427
// TODO: Implement sendStatus() method.
4528
}

tests/e2e/HTTPServicesTest.php

Lines changed: 28 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use PHPUnit\Framework\TestCase;
66
use Utopia\DI\Container;
77
use Utopia\Http\Adapter\FPM\Request;
8-
use Utopia\Http\Adapter\FPM\Response;
98
use Utopia\Http\Adapter\FPM\Server;
109
use Utopia\Http\Http;
1110

@@ -23,10 +22,8 @@ public function setUp(): void
2322
$platform = new TestPlatform();
2423
$platform->init('http');
2524

26-
$server = new Server();
27-
$this->http = new Http($server, new Container(), 'UTC');
28-
$this->http->setRequestClass(Request::class);
29-
$this->http->setResponseClass(Response::class);
25+
$server = new Server(new Container());
26+
$this->http = new Http($server, 'UTC');
3027
}
3128

3229
public function tearDown(): void
@@ -39,83 +36,74 @@ public function testRootAction()
3936
$_SERVER['REQUEST_METHOD'] = 'GET';
4037
$_SERVER['REQUEST_URI'] = '/';
4138

42-
$context = new Container();
43-
$context->set('response', fn () => new MockResponse());
44-
$context->set('request', fn () => new Request());
39+
$request = new Request();
40+
$response = new MockResponse();
4541

4642
\ob_start();
47-
$this->http->run($context);
48-
$response = \ob_get_contents();
43+
$this->http->run($request, $response);
44+
$result = \ob_get_contents();
4945
\ob_end_clean();
5046

51-
$this->assertEquals('Hello World!', $response);
47+
$this->assertEquals('Hello World!', $result);
5248
}
5349

5450
public function testChunkedAction()
5551
{
5652
$_SERVER['REQUEST_METHOD'] = 'GET';
5753
$_SERVER['REQUEST_URI'] = '/chunked';
5854

59-
$res = new MockResponse();
60-
$context = new Container();
61-
$context->set('response', fn () => $res);
62-
$context->set('request', fn () => new Request());
55+
$request = new Request();
56+
$response = new MockResponse();
6357

6458
\ob_start();
65-
$this->http->run($context);
66-
$response = \ob_get_contents();
59+
$this->http->run($request, $response);
60+
$result = \ob_get_contents();
6761
\ob_end_clean();
6862

69-
$this->assertEquals('Hello World!', $response);
63+
$this->assertEquals('Hello World!', $result);
7064
}
7165

7266
public function testRedirectAction()
7367
{
7468
$_SERVER['REQUEST_METHOD'] = 'GET';
7569
$_SERVER['REQUEST_URI'] = '/redirect';
7670

77-
$res = new MockResponse();
78-
$context = new Container();
79-
$context->set('response', fn () => $res);
80-
$context->set('request', fn () => new Request());
71+
$request = new Request();
72+
$response = new MockResponse();
8173

82-
$this->http->run($context);
74+
$this->http->run($request, $response);
8375

84-
$this->assertEquals('/', $res->getHeaders()['Location']);
76+
$this->assertEquals('/', $response->getHeaders()['Location']);
8577
}
8678

8779
public function testHook()
8880
{
8981
$_SERVER['REQUEST_METHOD'] = 'GET';
9082
$_SERVER['REQUEST_URI'] = '/';
9183

92-
$res = new MockResponse();
93-
$context = new Container();
94-
$context->set('response', fn () => $res);
95-
$context->set('request', fn () => new Request());
84+
$request = new Request();
85+
$response = new MockResponse();
9686

9787
\ob_start();
98-
$this->http->run($context);
99-
$response = \ob_get_contents();
88+
$this->http->run($request, $response);
89+
$result = \ob_get_contents();
10090
\ob_end_clean();
10191

102-
$this->assertEquals('Hello World!', $response);
103-
$this->assertEquals('init-called', $res->getHeaders()['x-init']);
92+
$this->assertEquals('Hello World!', $result);
93+
$this->assertEquals('init-called', $response->getHeaders()['x-init']);
10494

10595
$_SERVER['REQUEST_METHOD'] = 'GET';
10696
$_SERVER['REQUEST_URI'] = '/chunked';
10797

108-
$res1 = new MockResponse();
109-
$context = new Container();
110-
$context->set('response', fn () => $res1);
111-
$context->set('request', fn () => new Request());
98+
$request1 = new Request();
99+
$response1 = new MockResponse();
112100

113101
\ob_start();
114-
$this->http->run($context);
115-
$response = \ob_get_contents();
102+
$this->http->run($request1, $response1);
103+
$result = \ob_get_contents();
116104
\ob_end_clean();
117105

118-
$this->assertEquals('Hello World!', $response);
119-
$this->assertEquals('', ($res1->getHeaders()['x-init'] ?? ''));
106+
$this->assertEquals('Hello World!', $result);
107+
$this->assertEquals('', ($response1->getHeaders()['x-init'] ?? ''));
120108
}
121109
}

0 commit comments

Comments
 (0)