Skip to content

Commit ba2ba11

Browse files
Add loading state handling in PouiInternal and simplify new browse check in WebappInternal
1 parent cdccf78 commit ba2ba11

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

tir/technologies/poui_internal.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5657,6 +5657,8 @@ def _set_browse_filters(self, filters):
56575657
>>> self._filter_thf_browse(filters=[{'name': 'John'}], browse_div=browse_element)
56585658
"""
56595659

5660+
self.po_loading(selector='wa-dialog')
5661+
56605662
self._remove_filters_from_browse()
56615663

56625664
self.click_button(self.language.filters)
@@ -5928,6 +5930,8 @@ def SetButton(self, button, sub_item="", position=1, check_error=True):
59285930
:type check_error: bool
59295931
"""
59305932

5933+
self.po_loading(selector='wa-dialog')
5934+
59315935
button_normalized = str(button).lower().strip() if button is not None else ""
59325936
sub_item_normalized = str(sub_item).lower().strip() if sub_item is not None else ""
59335937

tir/technologies/webapp_internal.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2173,19 +2173,9 @@ def _simple_search_thf_browse(self, search_text, browse_div):
21732173
return
21742174

21752175
def _is_new_browse(self, throw_error=True, timeout=None):
2176-
21772176
browse_div = self._find_search_browse(throw_error=throw_error, timeout=timeout)
21782177

2179-
if browse_div and browse_div.name == 'thf-grid':
2180-
logger().info("Switching to the POUI method")
2181-
logger().info("Waiting loading...")
2182-
self.wait_element(term='po-loading', scrap_type=enum.ScrapType.CSS_SELECTOR, presence=False, main_container="body", twebview=True)
2183-
logger().info("Loading finished!")
2184-
2185-
return True
2186-
2187-
else:
2188-
return False
2178+
return browse_div.name == 'thf-grid' if browse_div else False
21892179

21902180
def longest_word(self, string):
21912181
words = string.split()

0 commit comments

Comments
 (0)