Fixed tracking of quest objectives

Author: todorivanov

CHANGELOG.md

@@ -15,6 +15,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [1.0.4] - 2026-02-04
+
+Building completion now updates quest objectives., daily quests now properly repeat after cooldown expires, Training system now properly updates quest objectives.
+
+### Fixed
+- **Repeatable Quests**: Fixed bug where the "Accept Quest" button was hidden for completed repeatable quests, preventing players from accepting them again
+- **Daily Quest Visibility**: Daily quests now always show in the Daily tab, even when on cooldown
+- **Building Quest Tracking**: Completing construction of a building now properly updates quest objectives with `type: 'build'` (e.g., "Build a training facility" in Building a Reputation quest)
+- **Training Quest Tracking**: Assigning a training regimen to a gladiator now correctly updates quest objectives with `type: 'train'` (e.g., "Daily Training" quest)
+
+### Added
+- **Cooldown Indicator**: Daily quests on cooldown now display remaining days (e.g., "⏳ 1 day left")
+- **Accept Again Button**: Repeatable quests show "Accept Again" button instead of "Accept Quest" when re-accepting
+
+---
+
 ## [1.0.3] - 2026-02-04
 
 Quest system fix for proper progress initialization.
@@ -128,6 +144,7 @@ This is the first public release of **Ludus Magnus: Reborn**, a complete Roman g
 
 | Version | Date | Highlights |
 |---------|------|------------|
+| 1.0.4 | 2026-02-04 | Fixed tracking of quest objectives |
 | 1.0.3 | 2026-02-04 | Fixed quest progress initialization timing issue |
 | 1.0.2 | 2026-02-04 | Quest progress initialization recognizes existing game state |
 | 1.0.1 | 2026-02-04 | Bug fixes, training/nutrition systems, balance improvements |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ludus-magnus-reborn",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "A Roman gladiator ludus management simulation game. Build your gladiator school, train legendary fighters, and conquer the arena.",
   "author": "Ludus Magnus: Reborn Contributors",
   "license": "MIT",

src/components/screens/DashboardScreen.tsx

@@ -10,8 +10,9 @@ import {
 } from '@features/game/gameSlice';
 import { addGold, spendGold, consumeResource } from '@features/player/playerSlice';
 import { NUTRITION_OPTIONS, type NutritionQuality } from '@data/training';
-import { tickCooldowns as tickQuestCooldowns } from '@features/quests/questsSlice';
+import { tickCooldowns as tickQuestCooldowns, incrementObjective } from '@features/quests/questsSlice';
 import { tickCooldowns as tickFactionCooldowns } from '@features/factions/factionsSlice';
+import { getQuestById } from '@data/quests';
 import { 
   updateConstructionProgress, 
   completeConstruction,
@@ -54,6 +55,9 @@ export const DashboardScreen: React.FC = () => {
   const staffState = useAppSelector(state => state.staff);
   const employees = staffState?.employees || [];
   const totalDailyWages = staffState?.totalDailyWages || 0;
+  
+  const questsState = useAppSelector(state => state.quests);
+  const activeQuests = questsState?.activeQuests || [];
 
   const [processingDay, setProcessingDay] = useState(false);
 
@@ -224,6 +228,24 @@ export const DashboardScreen: React.FC = () => {
         if (newDays <= 0) {
           dispatch(completeConstruction(building.id));
           events.push(`Construction complete: ${building.type}`);
+          
+          // Update quest objectives for building completion
+          activeQuests.forEach(activeQuest => {
+            const questDef = getQuestById(activeQuest.questId);
+            if (!questDef) return;
+            
+            questDef.objectives.forEach(objective => {
+              // Check if this objective is for building this specific type
+              if (objective.type === 'build' && objective.target === building.type) {
+                dispatch(incrementObjective({
+                  questId: activeQuest.questId,
+                  objectiveId: objective.id,
+                  amount: 1,
+                  required: objective.required,
+                }));
+              }
+            });
+          });
         } else {
           dispatch(updateConstructionProgress({ id: building.id, daysRemaining: newDays }));
         }
@@ -258,7 +280,7 @@ export const DashboardScreen: React.FC = () => {
     // Advance day
     dispatch(advanceDay());
     setProcessingDay(false);
-  }, [dispatch, currentDay, totalDailyWages, foodCosts, ludusFame, gold, roster, employees, buildings, resources]);
+  }, [dispatch, currentDay, totalDailyWages, foodCosts, ludusFame, gold, roster, employees, buildings, resources, activeQuests]);
 
   // Get phase icon
   const getPhaseIcon = (phase: string) => {

src/components/screens/QuestsScreen.tsx

@@ -19,6 +19,7 @@ import {
   getQuestById,
   getAvailableQuests,
   calculateQuestProgress,
+  DAILY_QUESTS,
   type Quest,
   type QuestDialogue,
   type QuestObjective,
@@ -86,7 +87,8 @@ export const QuestsScreen: React.FC = () => {
       case 'side':
         return availableQuests.filter(q => q.type === 'side' || q.type === 'event');
       case 'daily':
-        return availableQuests.filter(q => q.type === 'daily');
+        // Show all daily quests (available + on cooldown) so users can see when they'll be ready
+        return DAILY_QUESTS;
       case 'completed':
         return completedQuestIds.map(id => getQuestById(id)).filter((q): q is Quest => q !== undefined);
       default:
@@ -411,6 +413,7 @@ export const QuestsScreen: React.FC = () => {
                 quest={quest}
                 isCompleted={activeTab === 'completed'}
                 isActive={activeQuests.some(q => q.questId === quest.id)}
+                cooldownDays={questCooldowns[quest.id]}
                 onSelect={() => {
                   setSelectedQuest(quest);
                   setShowQuestModal(true);
@@ -432,6 +435,7 @@ export const QuestsScreen: React.FC = () => {
               quest={selectedQuest}
               activeData={getActiveQuestData(selectedQuest.id)}
               isCompleted={completedQuestIds.includes(selectedQuest.id)}
+              canAccept={availableQuests.some(q => q.id === selectedQuest.id)}
               onAccept={() => handleAcceptQuest(selectedQuest)}
               onClose={() => setShowQuestModal(false)}
             />
@@ -463,25 +467,31 @@ interface QuestCardProps {
   quest: Quest;
   isCompleted: boolean;
   isActive: boolean;
+  cooldownDays?: number;
   onSelect: () => void;
 }
 
 const QuestCard: React.FC<QuestCardProps> = ({
   quest,
   isCompleted,
   isActive,
+  cooldownDays,
   onSelect,
 }) => {
+  const isOnCooldown = cooldownDays !== undefined && cooldownDays > 0;
+  
   return (
     <div
       onClick={onSelect}
       className={clsx(
         'p-4 rounded-lg border cursor-pointer transition-all',
-        isCompleted
-          ? 'border-health-high bg-health-high/10'
-          : isActive
-            ? 'border-roman-gold-500 bg-roman-gold-500/10'
-            : 'border-roman-marble-600 bg-roman-marble-800 hover:border-roman-marble-500'
+        isOnCooldown
+          ? 'border-roman-marble-700 bg-roman-marble-900 opacity-75'
+          : isCompleted
+            ? 'border-health-high bg-health-high/10'
+            : isActive
+              ? 'border-roman-gold-500 bg-roman-gold-500/10'
+              : 'border-roman-marble-600 bg-roman-marble-800 hover:border-roman-marble-500'
       )}
     >
       <div className="flex items-start gap-3">
@@ -497,6 +507,11 @@ const QuestCard: React.FC<QuestCardProps> = ({
             {isActive && (
               <span className="text-xs px-2 py-0.5 bg-blue-600 rounded">Active</span>
             )}
+            {isOnCooldown && (
+              <span className="text-xs px-2 py-0.5 bg-roman-marble-600 rounded">
+                ⏳ {cooldownDays} day{cooldownDays > 1 ? 's' : ''} left
+              </span>
+            )}
           </div>
           <p className="text-sm text-roman-marble-400 mt-1 line-clamp-2">
             {quest.description}
@@ -591,6 +606,7 @@ interface QuestDetailViewProps {
   quest: Quest;
   activeData?: { objectives: { id: string; current: number; completed: boolean }[] };
   isCompleted: boolean;
+  canAccept: boolean; // true if quest can be accepted (not on cooldown, available)
   onAccept: () => void;
   onClose: () => void;
 }
@@ -599,6 +615,7 @@ const QuestDetailView: React.FC<QuestDetailViewProps> = ({
   quest,
   activeData,
   isCompleted,
+  canAccept,
   onAccept,
   onClose,
 }) => {
@@ -671,9 +688,9 @@ const QuestDetailView: React.FC<QuestDetailViewProps> = ({
         <Button variant="ghost" className="flex-1" onClick={onClose}>
           Close
         </Button>
-        {!isActive && !isCompleted && (
+        {!isActive && canAccept && (
           <Button variant="gold" className="flex-1" onClick={onAccept}>
-            Accept Quest
+            {isCompleted && quest.repeatable ? 'Accept Again' : 'Accept Quest'}
           </Button>
         )}
       </div>

src/components/screens/TrainingScreen.tsx

@@ -6,6 +6,7 @@ import {
   setNutrition,
   learnSkill,
 } from '@features/gladiators/gladiatorsSlice';
+import { incrementObjective } from '@features/quests/questsSlice';
 import { MainLayout } from '@components/layout';
 import { Card, CardHeader, CardTitle, CardContent, Button, ProgressBar } from '@components/ui';
 import { 
@@ -22,6 +23,7 @@ import {
   canLearnSkill,
 } from '@data/skillTrees';
 import { GLADIATOR_CLASSES } from '@data/gladiatorClasses';
+import { getQuestById } from '@data/quests';
 import type { Gladiator } from '@/types';
 import { clsx } from 'clsx';
 
@@ -32,6 +34,8 @@ export const TrainingScreen: React.FC = () => {
   const { roster } = useAppSelector(state => state.gladiators);
   const { buildings } = useAppSelector(state => state.ludus);
   const { resources } = useAppSelector(state => state.player);
+  const questsState = useAppSelector(state => state.quests);
+  const activeQuests = questsState?.activeQuests || [];
 
   const [selectedGladiatorId, setSelectedGladiatorId] = useState<string | null>(
     roster.length > 0 ? roster[0].id : null
@@ -44,6 +48,26 @@ export const TrainingScreen: React.FC = () => {
   // Handle training selection
   const handleSetTraining = (gladiatorId: string, trainingType: TrainingType | null) => {
     dispatch(setTrainingRegimen({ gladiatorId, trainingType }));
+    
+    // Update quest objectives for training if a training type is selected (not null/stopping)
+    if (trainingType) {
+      activeQuests.forEach(activeQuest => {
+        const questDef = getQuestById(activeQuest.questId);
+        if (!questDef) return;
+        
+        questDef.objectives.forEach(objective => {
+          if (objective.type === 'train') {
+            // For 'train' objectives, increment by 1 when assigning training
+            dispatch(incrementObjective({
+              questId: activeQuest.questId,
+              objectiveId: objective.id,
+              amount: 1,
+              required: objective.required,
+            }));
+          }
+        });
+      });
+    }
   };
 
   // Handle nutrition selection