Skip to content

Commit f88cc53

Browse files
Merge pull request #14 from the-hotels-network/fix-encoding-whitespace-rfc3986
fix - force to use whitespace defined on rfc3986.
2 parents cf3af7a + b01891a commit f88cc53

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

pipe.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ func (p *Pipe) GetParameters() string {
2929
}
3030
}
3131

32-
return p.Parameters.Encode()
32+
return strings.Replace(p.Parameters.Encode(), "+", "%20", -1)
3333
}

pipe_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ func TestGetParameters(t *testing.T) {
1313
params := url.Values{}
1414
params.Add("start_date", "2022-05-01")
1515
params.Add("end_date", "2022-05-30")
16+
params.Add("request_at", "2023-05-01 23:59:59")
1617
params.Add("id", "1")
1718
params.Add("id", "2")
1819
params.Add("id", "3")
@@ -27,5 +28,5 @@ func TestGetParameters(t *testing.T) {
2728
},
2829
}
2930

30-
assert.Equal(t, p.GetParameters(), "end_date=2022-05-30&id=1%2C2%2C3%2C4&start_date=2022-05-01")
31+
assert.Equal(t, p.GetParameters(), "end_date=2022-05-30&id=1%2C2%2C3%2C4&request_at=2023-05-01%2023%3A59%3A59&start_date=2022-05-01")
3132
}

request_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func TestRequestWithRequestParamInspect(t *testing.T) {
8888
`{"data":[{"Col1": "1", "Col2": 2}],"rows":1,"statistics":{"elapsed":0.00091042,"rows_read": 4,"bytes_read": 296}}`,
8989
func(r *http.Request) {
9090
assert.Contains(t, r.URL.String(), "start_date=2023-05-01")
91-
assert.Contains(t, r.URL.String(), "request_at=2023-05-01+23%3A59%3A5")
91+
assert.Contains(t, r.URL.String(), "request_at=2023-05-01%2023%3A59%3A59")
9292
assert.Contains(t, r.URL.String(), "end_date=2023-05-31")
9393
assert.Contains(t, r.URL.String(), "currency=EUR")
9494
},

0 commit comments

Comments
 (0)