[SDK Sentinel] Stabilize legacy query integration test ordering - #1511
Open
sdk-sentinel-bot wants to merge 1 commit into
Conversation
Member
|
@sdk-sentinel-bot The comment that mentions the activation doesn't have a query is very confusing now, because it obviously won't have the query now that it was completed before the query was issued. We need to fix / move the comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Stabilize
simple_query_legacyafter Windows CI observed a query activation before the timer activation the test expected. The [preceding main run](https://github.com/temporalio/sdk-rust/actions/runs/32294857783) passed; the [next main run](https://github.com/temporalio/sdk-rust/actions/runs/32311849105) exposed the latent race.Root cause
The test started its query before polling the outstanding timer workflow task. Depending on scheduling, the server could deliver the query activation first, contradicting the test's assumed order.
Fix
Poll and verify the timer activation before the query exists, retain it, and complete it after the query begins. This establishes the required order without retries, weaker assertions, or additional sleeps.
Validation
The canonical formatting, lint, test-lint, and check script passes. The focused integration test could not compile locally because the sandbox denied the native zstd build, so the Windows integration job remains required.
Validation status:
validation-incompletehighmediummediumstandard— 1 changed file; 1.9 KiBunavailable— The Linux integration harness could not compile zstd-sys under the investigation sandbox, so natural reproduction was unavailable.not-run— The existing failing integration test was made deterministic but could not be executed locally; repository compilation and lint checks passed.Cargo formatting, linting, and checks) — passedCargo formatting, linting, and checks) — passedInvestigator-run checks
CARGO_BUILD_JOBS=2 timeout 180 cargo integ-test simple_query_legacy— failed; 2 attempt(s). Neither attempt reached the test: one was stopped when rustup attempted external synchronization, and the offline installed-toolchain attempt failed compiling zstd-sys with Operation not permitted..ci-flake-runtime/input/validate.sh— passed; 3 attempt(s). The first launch was stopped before checks when rustup attempted synchronization; two executions using installed toolchains passed, including the final patch.Required target CI
Residual risks
Automation provenance
d9efc491cfde59fe2159ba2c6942ebdd83c2808eIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-08-19 23:26 UTC2026-08-19 23:26 UTC