review update

Author: ewaostrowska

.github/workflows/prepare-release-3.yml

@@ -27,15 +27,6 @@ on:
         description: 'Optional bootstrap generator version for circular dependency validation'
         required: false
         type: string
-      dry_run:
-        description: 'Validate and build without publishing/releasing artifacts (PR is still created)'
-        required: true
-        default: 'true'
-        type: choice
-        options:
-          - 'true'
-          - 'false'
-
 permissions:
   contents: write
   pull-requests: write
@@ -44,8 +35,6 @@ jobs:
   prepare:
     runs-on: ubuntu-latest
     env:
-      MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
-      MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
       CODEGEN_VERSION: ${{ inputs.codegen_version }}
       NEXT_CODEGEN_SNAPSHOT_VERSION: ${{ inputs.next_codegen_snapshot_version }}
       RELEASE_GENERATORS: ${{ inputs.release_generators }}
@@ -66,6 +55,9 @@ jobs:
 
       - name: Set up Java and Maven
         uses: actions/setup-java@v5
+        env:
+          MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
+          MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
         with:
           java-version: '17'
           distribution: temurin

.github/workflows/release-codegen-3.yml

@@ -53,13 +53,7 @@ on:
           - 'false'
 
 permissions:
-  contents: write
-  pull-requests: write
-
-env:
-  MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
-  MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
-  MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_PRIVATE_PASSPHRASE }}
+  contents: read
 
 jobs:
   validate:
@@ -89,6 +83,10 @@ jobs:
 
       - name: Set up Java and Maven
         uses: actions/setup-java@v5
+        env:
+          MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
+          MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
+          MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_PRIVATE_PASSPHRASE }}
         with:
           java-version: '17'
           distribution: temurin
@@ -128,6 +126,9 @@ jobs:
 
       - name: Set up Java and Maven
         uses: actions/setup-java@v5
+        env:
+          MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
+          MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
         with:
           java-version: '17'
           distribution: temurin
@@ -166,6 +167,10 @@ jobs:
 
       - name: Set up Java and Maven
         uses: actions/setup-java@v5
+        env:
+          MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
+          MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
+          MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_PRIVATE_PASSPHRASE }}
         with:
           java-version: '17'
           distribution: temurin
@@ -202,6 +207,8 @@ jobs:
 
   codegen:
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
     needs:
       - validate
       - generators
@@ -218,6 +225,10 @@ jobs:
 
       - name: Set up Java and Maven
         uses: actions/setup-java@v5
+        env:
+          MAVEN_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
+          MAVEN_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
+          MAVEN_GPG_PASSPHRASE: ${{ secrets.OSSRH_GPG_PRIVATE_PASSPHRASE }}
         with:
           java-version: '17'
           distribution: temurin
@@ -437,7 +448,14 @@ jobs:
 
   post_release_pr:
     runs-on: ubuntu-latest
-    needs: codegen
+    permissions:
+      contents: write
+      pull-requests: write
+    needs:
+      - codegen
+      - docker
+      - online_deploy
+    if: always() && needs.codegen.result == 'success' && (needs.docker.result == 'success' || needs.docker.result == 'skipped') && (needs.online_deploy.result == 'success' || needs.online_deploy.result == 'skipped')
     env:
       NEXT_CODEGEN_SNAPSHOT_VERSION: ${{ needs.codegen.outputs.next_codegen_snapshot_version }}
       GENERATORS_VERSION: ${{ needs.codegen.outputs.generators_version }}

CI/release/common.sh

@@ -62,6 +62,11 @@ maven_project_version() {
   mvn -q -Dexec.executable="echo" -Dexec.args='${project.version}' --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec
 }
 
+maven_property_value() {
+  local property_name="$1"
+  mvn -q -Dexec.executable="echo" -Dexec.args="\${${property_name}}" --non-recursive org.codehaus.mojo:exec-maven-plugin:1.3.1:exec
+}
+
 curl_metadata() {
   local url="$1"
   curl --fail --silent --show-error --location --retry 5 --retry-delay 2 --connect-timeout 20 --max-time 90 "${url}"

CI/release/resolve-release-versions.sh

@@ -96,7 +96,8 @@ else
     generators_version="${generators_version_override}"
     require_release_version "generators_version_override" "${generators_version}"
   else
-    generators_version="$(latest_released_generators_version)"
+    generators_version="$(maven_property_value "swagger-codegen-generators-version")"
+    require_release_version "swagger-codegen-generators-version from pom.xml" "${generators_version}"
   fi
   bootstrap_generators_version="${generators_version}"