ci: per-Ruby Gemfile so modern Rubies run latest libs#2
Merged
Conversation
Replace the global `parallel < 2` pin (which held every Ruby to the old lib) with a dedicated gemfiles/ruby_3_2.gemfile that eval_gemfiles the root Gemfile and pins only the gems whose latest majors dropped 3.2. The 3.2 matrix row uses it via BUNDLE_GEMFILE; every other Ruby uses the root Gemfile with up-to-date deps (parallel 2.x). Each gemfile keeps its own lockfile.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 264 264
=========================================
Hits 264 264 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the global
parallel < 2pin with a dedicatedgemfiles/ruby_3_2.gemfileso each Ruby runs the newest libs it can:Gemfile— un-pinned; modern Rubies (3.3 / 3.4 / 4.0 / head) get up-to-date deps (parallel 2.x, …).gemfiles/ruby_3_2.gemfile—eval_gemfiles the root and pins only the gems whose latest majors dropped 3.2 (currently justparallel < 2). Has its own lockfile.BUNDLE_GEMFILE; every other row uses the rootGemfile.Why
parallel 2.x(a rubocop dependency) requires Ruby >= 3.3, which brokebundle installon the 3.2 row. The previous fix pinnedparallel < 2globally — correct, but it held every Ruby to the old lib. This keeps 3.2 green without holding modern Rubies back.Verified locally (Ruby 4.0.5)
parallel 2.1.0;bundle exec rakegreen (rubocop · rbs · 57 tests).BUNDLE_GEMFILE=gemfiles/ruby_3_2.gemfile→parallel 1.28.0; same gate green.Note
dependabot.yml's bundler updater watches/only, sogemfiles/ruby_3_2.gemfile.lockwon't get automatic updates. Can add a second bundler entry for it if wanted.