cluster: fix log message on leadership change to be more readable

Author: svix-jbrown

src/core/cluster/background.rs

@@ -167,7 +167,7 @@ async fn leadership_changes(handle: RaftState) -> tokio::sync::broadcast::Receiv
                 |m| {
                     let mut l = last_leader.lock().unwrap();
                     if m.current_leader != *l {
-                        tracing::debug!(old_leader = ?l, new_leader = ?m, "leader has changed");
+                        tracing::debug!(old_leader = ?l, new_leader = ?m.current_leader, "leader has changed");
                         *l = m.current_leader;
                         if tx.send(m.current_leader).is_err() {
                             return true;

src/core/cluster/node.rs

@@ -88,9 +88,7 @@ impl Node {
     }
 }
 
-#[derive(
-    Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Default, Hash, Serialize, Deserialize,
-)]
+#[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Default, Hash, Serialize, Deserialize)]
 #[serde(transparent)]
 pub struct NodeId {
     #[serde(with = "uuid::serde::simple")]
@@ -111,6 +109,12 @@ impl JsonSchema for NodeId {
     }
 }
 
+impl std::fmt::Debug for NodeId {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "NodeId({})", self.inner.simple())
+    }
+}
+
 impl std::fmt::Display for NodeId {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         self.inner.simple().fmt(f)