refactor(desktop): split LinkHoverTooltip hook/component, tighten modifier listener

- Move useLinkHoverState into its own hooks/ folder (was exported alongside
  the component in violation of the one-component-per-file rule).
- Effect now re-subscribes on hover start/end only (deps: hovering boolean),
  not on every modifier change.
- Filter to Meta/Control/Shift/Alt key events so typing a letter while
  hovering doesn't churn state.
- Skip setState when modifier/shift values didn't actually change, avoiding
  identity-change re-renders on repeat keydowns.
- Extract tooltip offset constant.

Author: saddlepaddle

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx

@@ -25,10 +25,8 @@ import { ScrollToBottomButton } from "renderer/screens/main/components/Workspace
 import { TerminalSearch } from "renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/TerminalSearch";
 import { useTheme } from "renderer/stores/theme";
 import { resolveTerminalThemeType } from "renderer/stores/theme/utils";
-import {
-	LinkHoverTooltip,
-	useLinkHoverState,
-} from "./components/LinkHoverTooltip";
+import { LinkHoverTooltip } from "./components/LinkHoverTooltip";
+import { useLinkHoverState } from "./hooks/useLinkHoverState";
 import { useTerminalAppearance } from "./hooks/useTerminalAppearance";
 
 interface TerminalPaneProps {

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/LinkHoverTooltip/LinkHoverTooltip.tsx

@@ -1,17 +1,12 @@
 import type { ExternalApp } from "@superset/local-db";
-import { useCallback, useEffect, useState } from "react";
+import { useEffect, useState } from "react";
 import { createPortal } from "react-dom";
 import { getAppOption } from "renderer/components/OpenInExternalDropdown/constants";
 import type { LinkHoverInfo } from "renderer/lib/terminal/terminal-runtime-registry";
 import { electronTrpcClient } from "renderer/lib/trpc-client";
+import type { HoveredLink } from "../../hooks/useLinkHoverState";
 
-interface HoveredLink {
-	clientX: number;
-	clientY: number;
-	info: LinkHoverInfo;
-	modifier: boolean;
-	shift: boolean;
-}
+const TOOLTIP_OFFSET_PX = 14;
 
 interface LinkHoverTooltipProps {
 	hoveredLink: HoveredLink | null;
@@ -64,52 +59,12 @@ export function LinkHoverTooltip({ hoveredLink }: LinkHoverTooltipProps) {
 		<div
 			className="pointer-events-none fixed z-50 w-fit rounded-md bg-foreground px-3 py-1.5 text-xs text-background"
 			style={{
-				left: hoveredLink.clientX + 14,
-				top: hoveredLink.clientY + 14,
+				left: hoveredLink.clientX + TOOLTIP_OFFSET_PX,
+				top: hoveredLink.clientY + TOOLTIP_OFFSET_PX,
 			}}
 		>
 			{label}
 		</div>,
 		document.body,
 	);
 }
-
-export function useLinkHoverState() {
-	const [hoveredLink, setHoveredLink] = useState<HoveredLink | null>(null);
-
-	useEffect(() => {
-		if (!hoveredLink) return;
-		const update = (event: KeyboardEvent) => {
-			setHoveredLink((prev) => {
-				if (!prev) return null;
-				return {
-					...prev,
-					modifier: event.metaKey || event.ctrlKey,
-					shift: event.shiftKey,
-				};
-			});
-		};
-		window.addEventListener("keydown", update);
-		window.addEventListener("keyup", update);
-		return () => {
-			window.removeEventListener("keydown", update);
-			window.removeEventListener("keyup", update);
-		};
-	}, [hoveredLink]);
-
-	const onHover = useCallback((event: MouseEvent, info: LinkHoverInfo) => {
-		setHoveredLink({
-			clientX: event.clientX,
-			clientY: event.clientY,
-			info,
-			modifier: event.metaKey || event.ctrlKey,
-			shift: event.shiftKey,
-		});
-	}, []);
-
-	const onLeave = useCallback(() => {
-		setHoveredLink(null);
-	}, []);
-
-	return { hoveredLink, onHover, onLeave };
-}

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/LinkHoverTooltip/index.ts

@@ -1 +1 @@
-export { LinkHoverTooltip, useLinkHoverState } from "./LinkHoverTooltip";
+export { LinkHoverTooltip } from "./LinkHoverTooltip";

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/hooks/useLinkHoverState/index.ts

@@ -0,0 +1 @@
+export { type HoveredLink, useLinkHoverState } from "./useLinkHoverState";

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/hooks/useLinkHoverState/useLinkHoverState.ts

@@ -0,0 +1,55 @@
+import { useCallback, useEffect, useState } from "react";
+import type { LinkHoverInfo } from "renderer/lib/terminal/terminal-runtime-registry";
+
+export interface HoveredLink {
+	clientX: number;
+	clientY: number;
+	info: LinkHoverInfo;
+	modifier: boolean;
+	shift: boolean;
+}
+
+const MODIFIER_KEYS = new Set(["Meta", "Control", "Shift", "Alt"]);
+
+export function useLinkHoverState() {
+	const [hoveredLink, setHoveredLink] = useState<HoveredLink | null>(null);
+	const hovering = hoveredLink !== null;
+
+	useEffect(() => {
+		if (!hovering) return;
+		const update = (event: KeyboardEvent) => {
+			if (!MODIFIER_KEYS.has(event.key)) return;
+			setHoveredLink((prev) => {
+				if (!prev) return null;
+				const nextModifier = event.metaKey || event.ctrlKey;
+				const nextShift = event.shiftKey;
+				if (prev.modifier === nextModifier && prev.shift === nextShift) {
+					return prev;
+				}
+				return { ...prev, modifier: nextModifier, shift: nextShift };
+			});
+		};
+		window.addEventListener("keydown", update);
+		window.addEventListener("keyup", update);
+		return () => {
+			window.removeEventListener("keydown", update);
+			window.removeEventListener("keyup", update);
+		};
+	}, [hovering]);
+
+	const onHover = useCallback((event: MouseEvent, info: LinkHoverInfo) => {
+		setHoveredLink({
+			clientX: event.clientX,
+			clientY: event.clientY,
+			info,
+			modifier: event.metaKey || event.ctrlKey,
+			shift: event.shiftKey,
+		});
+	}, []);
+
+	const onLeave = useCallback(() => {
+		setHoveredLink(null);
+	}, []);
+
+	return { hoveredLink, onHover, onLeave };
+}