feat(desktop): modifier-keyed v2 terminal file links + folder sidebar reveal

Replaces the settings-based branch with a modifier-key pattern:

- Cmd/Ctrl-click a file path → opens in an in-app FilePane.
- Cmd/Ctrl+Shift-click a file or directory → opens in the external editor (with an upfront toast for remote workspaces, same pattern as FilesTab's Open in editor guard).
- Cmd/Ctrl-click a directory path → force-opens the sidebar, reveals the folder in the file tree (ancestors expand, row scrolls into view and highlights).

Implementation reuses the existing selectedFilePath → fileTree.reveal machinery in FilesTab by promoting selectedFilePath from a pane-store derivation to a useState, synced from the active file pane via useEffect. Folder focus is just a direct setSelectedFilePath — the existing sidebar code path handles reveal + scroll + highlight without changes. Folder paths now also flow through getParentForCreation, so the "New File" toolbar button creates inside the focused folder.

Three callbacks (onOpenFile / onRevealPath / onOpenExternal) are plumbed from page.tsx through usePaneRegistry to TerminalPane. The shift-modifier path goes through openExternal, which checks workspaceHost.hostMachineId !== machineId and toasts for remote workspaces instead of firing a mutation the remote won't satisfy.

v1 code untouched; DB schema untouched; v2 settings UI untouched (terminalLinkBehavior still honored by v1).

Author: saddlepaddle

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx

@@ -1,5 +1,4 @@
 import type { RendererContext } from "@superset/panes";
-import { toast } from "@superset/ui/sonner";
 import { workspaceTrpc } from "@superset/workspace-client";
 import "@xterm/xterm/css/xterm.css";
 import {
@@ -16,7 +15,6 @@ import {
 } from "renderer/lib/terminal/terminal-runtime-registry";
 import { electronTrpcClient } from "renderer/lib/trpc-client";
 import type {
-	FilePaneData,
 	PaneViewerData,
 	TerminalPaneData,
 } from "renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/types";
@@ -30,6 +28,12 @@ import { useTerminalAppearance } from "./hooks/useTerminalAppearance";
 interface TerminalPaneProps {
 	ctx: RendererContext<PaneViewerData>;
 	workspaceId: string;
+	onOpenFile: (path: string, openInNewTab?: boolean) => void;
+	onRevealPath: (path: string) => void;
+	onOpenExternal: (
+		path: string,
+		opts?: { line?: number; column?: number },
+	) => void;
 }
 
 function subscribeToState(terminalId: string) {
@@ -41,7 +45,13 @@ function getConnectionState(terminalId: string): ConnectionState {
 	return terminalRuntimeRegistry.getConnectionState(terminalId);
 }
 
-export function TerminalPane({ ctx, workspaceId }: TerminalPaneProps) {
+export function TerminalPane({
+	ctx,
+	workspaceId,
+	onOpenFile,
+	onRevealPath,
+	onOpenExternal,
+}: TerminalPaneProps) {
 	const paneData = ctx.pane.data as TerminalPaneData;
 	const { terminalId } = paneData;
 	const containerRef = useRef<HTMLDivElement | null>(null);
@@ -125,8 +135,12 @@ export function TerminalPane({ ctx, workspaceId }: TerminalPaneProps) {
 	const statPathRef = useRef(statPathMutation.mutateAsync);
 	statPathRef.current = statPathMutation.mutateAsync;
 
-	const paneStoreRef = useRef(ctx.store);
-	paneStoreRef.current = ctx.store;
+	const onOpenFileRef = useRef(onOpenFile);
+	onOpenFileRef.current = onOpenFile;
+	const onRevealPathRef = useRef(onRevealPath);
+	onRevealPathRef.current = onRevealPath;
+	const onOpenExternalRef = useRef(onOpenExternal);
+	onOpenExternalRef.current = onOpenExternal;
 
 	useEffect(() => {
 		terminalRuntimeRegistry.setLinkHandlers(terminalId, {
@@ -145,36 +159,21 @@ export function TerminalPane({ ctx, workspaceId }: TerminalPaneProps) {
 					return null;
 				}
 			},
-			onFileLinkClick: async (event, link) => {
+			onFileLinkClick: (event, link) => {
 				if (!event.metaKey && !event.ctrlKey) return;
 				event.preventDefault();
-				const behavior =
-					await electronTrpcClient.settings.getTerminalLinkBehavior
-						.query()
-						.catch(() => "file-viewer" as const);
-				if (behavior === "file-viewer" && !link.isDirectory) {
-					paneStoreRef.current.getState().openPane({
-						pane: {
-							kind: "file",
-							data: {
-								filePath: link.resolvedPath,
-								mode: "editor",
-								hasChanges: false,
-							} satisfies FilePaneData,
-						},
-					});
-					return;
-				}
-				electronTrpcClient.external.openFileInEditor
-					.mutate({
-						path: link.resolvedPath,
+				if (event.shiftKey) {
+					onOpenExternalRef.current(link.resolvedPath, {
 						line: link.row,
 						column: link.col,
-					})
-					.catch((error) => {
-						console.error("[v2 Terminal] Failed to open file:", error);
-						toast.error("Failed to open file in editor");
 					});
+					return;
+				}
+				if (link.isDirectory) {
+					onRevealPathRef.current(link.resolvedPath);
+				} else {
+					onOpenFileRef.current(link.resolvedPath);
+				}
 			},
 			onUrlClick: (url) => {
 				electronTrpcClient.external.openUrl.mutate(url).catch((error) => {

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx

@@ -140,8 +140,18 @@ function DiffViewModeToggle() {
 	);
 }
 
+interface UsePaneRegistryOptions {
+	onOpenFile: (path: string, openInNewTab?: boolean) => void;
+	onRevealPath: (path: string) => void;
+	onOpenExternal: (
+		path: string,
+		opts?: { line?: number; column?: number },
+	) => void;
+}
+
 export function usePaneRegistry(
 	workspaceId: string,
+	{ onOpenFile, onRevealPath, onOpenExternal }: UsePaneRegistryOptions,
 ): PaneRegistry<PaneViewerData> {
 	const clearShortcut = useHotkeyDisplay("CLEAR_TERMINAL").text;
 	const scrollToBottomShortcut = useHotkeyDisplay("SCROLL_TO_BOTTOM").text;
@@ -237,7 +247,13 @@ export function usePaneRegistry(
 				getIcon: () => <TerminalSquare className="size-4" />,
 				getTitle: () => "Terminal",
 				renderPane: (ctx: RendererContext<PaneViewerData>) => (
-					<TerminalPane ctx={ctx} workspaceId={workspaceId} />
+					<TerminalPane
+						ctx={ctx}
+						workspaceId={workspaceId}
+						onOpenFile={onOpenFile}
+						onRevealPath={onRevealPath}
+						onOpenExternal={onOpenExternal}
+					/>
 				),
 				contextMenuActions: (_ctx, defaults) => {
 					const terminalActions: ContextMenuActionConfig<PaneViewerData>[] = [
@@ -411,6 +427,13 @@ export function usePaneRegistry(
 				},
 			},
 		}),
-		[workspaceId, clearShortcut, scrollToBottomShortcut],
+		[
+			workspaceId,
+			clearShortcut,
+			scrollToBottomShortcut,
+			onOpenFile,
+			onRevealPath,
+			onOpenExternal,
+		],
 	);
 }

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsx

@@ -5,15 +5,18 @@ import {
 	ResizablePanel,
 	ResizablePanelGroup,
 } from "@superset/ui/resizable";
+import { toast } from "@superset/ui/sonner";
 import { workspaceTrpc } from "@superset/workspace-client";
 import { eq } from "@tanstack/db";
 import { useLiveQuery } from "@tanstack/react-db";
 import { createFileRoute } from "@tanstack/react-router";
-import { useCallback, useMemo, useState } from "react";
+import { useCallback, useEffect, useMemo, useState } from "react";
 import { HiMiniXMark } from "react-icons/hi2";
 import { TbLayoutColumns, TbLayoutRows } from "react-icons/tb";
 import { HotkeyLabel, useHotkey } from "renderer/hotkeys";
+import { electronTrpcClient } from "renderer/lib/trpc-client";
 import { useCollections } from "renderer/routes/_authenticated/providers/CollectionsProvider";
+import { useLocalHostService } from "renderer/routes/_authenticated/providers/LocalHostServiceProvider";
 import { CommandPalette } from "renderer/screens/main/components/CommandPalette";
 import {
 	toAbsoluteWorkspacePath,
@@ -92,6 +95,7 @@ function WorkspaceContent({
 	workspaceId: string;
 	workspaceName: string;
 }) {
+	const collections = useCollections();
 	const { localWorkspaceState, store } = useV2WorkspacePaneLayout({
 		projectId,
 		workspaceId,
@@ -102,8 +106,6 @@ function WorkspaceContent({
 		projectId,
 	});
 	useConsumePendingLaunch({ workspaceId, store });
-	const paneRegistry = usePaneRegistry(workspaceId);
-	const defaultContextMenuActions = useDefaultContextMenuActions(paneRegistry);
 
 	const workspaceQuery = workspaceTrpc.workspace.get.useQuery({
 		id: workspaceId,
@@ -112,14 +114,40 @@ function WorkspaceContent({
 
 	const { recentFiles, recordView } = useRecentlyViewedFiles(workspaceId);
 
-	const selectedFilePath = useStore(store, (s) => {
+	const { machineId } = useLocalHostService();
+	const { data: workspacesWithHost = [] } = useLiveQuery(
+		(q) =>
+			q
+				.from({ workspaces: collections.v2Workspaces })
+				.leftJoin({ hosts: collections.v2Hosts }, ({ workspaces, hosts }) =>
+					eq(workspaces.hostId, hosts.id),
+				)
+				.where(({ workspaces }) => eq(workspaces.id, workspaceId))
+				.select(({ hosts }) => ({
+					hostMachineId: hosts?.machineId ?? null,
+				})),
+		[collections, workspaceId],
+	);
+	const workspaceHost = workspacesWithHost[0];
+
+	const activeFilePanePath = useStore(store, (s) => {
 		const tab = s.tabs.find((t) => t.id === s.activeTabId);
 		if (!tab?.activePaneId) return undefined;
 		const pane = tab.panes[tab.activePaneId];
 		if (pane?.kind === "file") return (pane.data as FilePaneData).filePath;
 		return undefined;
 	});
 
+	const [selectedFilePath, setSelectedFilePath] = useState<string | undefined>(
+		activeFilePanePath,
+	);
+
+	useEffect(() => {
+		if (activeFilePanePath !== undefined) {
+			setSelectedFilePath(activeFilePanePath);
+		}
+	}, [activeFilePanePath]);
+
 	const openFilePathsKey = useStore(store, (s) =>
 		s.tabs
 			.flatMap((t) =>
@@ -179,6 +207,42 @@ function WorkspaceContent({
 		[store, worktreePath, recordView],
 	);
 
+	const revealPath = useCallback(
+		(path: string) => {
+			collections.v2WorkspaceLocalState.update(workspaceId, (draft) => {
+				draft.rightSidebarOpen = true;
+			});
+			setSelectedFilePath(path);
+		},
+		[collections, workspaceId],
+	);
+
+	const openExternal = useCallback(
+		(path: string, opts?: { line?: number; column?: number }) => {
+			if (workspaceHost && workspaceHost.hostMachineId !== machineId) {
+				toast.error("Can't open remote workspace paths in an external editor");
+				return;
+			}
+			electronTrpcClient.external.openFileInEditor
+				.mutate({ path, line: opts?.line, column: opts?.column })
+				.catch((error) => {
+					console.error(
+						"[v2 Terminal] Failed to open in external editor:",
+						error,
+					);
+					toast.error("Failed to open in external editor");
+				});
+		},
+		[workspaceHost, machineId],
+	);
+
+	const paneRegistry = usePaneRegistry(workspaceId, {
+		onOpenFile: openFilePane,
+		onRevealPath: revealPath,
+		onOpenExternal: openExternal,
+	});
+	const defaultContextMenuActions = useDefaultContextMenuActions(paneRegistry);
+
 	const openDiffPane = useCallback(
 		(filePath: string) => {
 			const state = store.getState();