Fix history view for soroban on first render#880
Open
leofelix077 wants to merge 1 commit into
Open
Conversation
leofelix077
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Removes flex-1 justify-center from the shared TransactionDetailsContent card so Soroban transaction detail content renders at its intrinsic size on first paint, avoiding being squished while the bottom sheet's layout-dependent second render settles. CreateAccountTransactionDetailsContent preserves the previous behavior by passing className="justify-center" explicitly.
Changes:
- Drop
flex-1 justify-centerfrom the base wrapper classes inTransactionDetailsContent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
iOS Simulator preview build is ready: https://github.com/stellar/freighter-mobile/releases/tag/untagged-5e5d1e75338833c52018 (SDF collaborators only — install instructions in the release description) |
leofelix077
removed
the
don't review yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #849
Small fix to remove flex and justify, so content doesnt get squished on first load until layouting runs
Before
Screen.Recording.2026-05-29.at.09.21.33.mov
After
Screen.Recording.2026-05-29.at.09.20.55.mov
On device
ScreenRecording_05-29-2026.10-33-46_1.MP4
Android emulator
Screen.Recording.2026-05-29.at.10.37.41.mov
Checklist
PR structure
Testing
Release