fixes

Author: Rob-Hague

.editorconfig

@@ -620,12 +620,21 @@ dotnet_diagnostic.MA0112.severity = warning
 # MA0165: Make interpolated string
 dotnet_diagnostic.MA0165.severity = none
 
+# MA0173 - Use LazyInitializer.EnsureInitialize
+dotnet_diagnostic.MA0173.severity = none
+
 # MA0182: Avoid unused internal types
 dotnet_diagnostic.MA0182.severity = none
 
 # MA0184: Do not use interpolated string without parameters
 dotnet_diagnostic.MA0184.severity = none
 
+# MA0190 - Use partial property instead of partial method for GeneratedRegex
+dotnet_diagnostic.MA0190.severity = none
+
+# MA0192 - Use HasFlag instead of bitwise checks
+dotnet_diagnostic.MA0192.severity = none
+
 #### MSTest rules ####
 
 # MSTEST0015: Test method should not be ignored

src/Renci.SshNet/Netconf/NetConfSession.cs

@@ -129,7 +129,7 @@ protected override void OnDataReceived(ArraySegment<byte> data)
             {
                 _ = _data.Append(chunk);
 
-                if (!chunk.Contains(Prompt))
+                if (!chunk.Contains(Prompt, StringComparison.Ordinal))
                 {
                     return;
                 }
@@ -194,7 +194,7 @@ protected override void OnDataReceived(ArraySegment<byte> data)
             {
                 _ = _data.Append(chunk);
 
-                if (!chunk.Contains(Prompt))
+                if (!chunk.Contains(Prompt, StringComparison.Ordinal))
                 {
                     return;
                 }

src/Renci.SshNet/PrivateKeyFile.SSHCOM.cs

@@ -70,7 +70,7 @@ public Key Parse()
                     throw new SshException("Invalid passphrase.");
                 }
 
-                if (keyType.Contains("rsa"))
+                if (keyType.Contains("rsa", StringComparison.Ordinal))
                 {
                     var exponent = ReadBigIntWithBits(keyReader);
                     var d = ReadBigIntWithBits(keyReader);

test/Renci.SshNet.Tests/Classes/Security/CertificateHostAlgorithmTest.cs

@@ -287,7 +287,7 @@ public void CertificateBadCASignature_VerifySignatureReturnsFalse()
                 "PD7/nXcyxnY3zALlPQTxb19EVx5lz58BS96gg=";
 
             char[] chars = goodCertString.ToCharArray();
-            chars[^10] = 'a';
+            chars[chars.Length - 1] = 'a';
             string badCertString = new string(chars);
 
             Assert.IsTrue(VerifySignature(goodCertString));