Merge pull request #1597 from squidowl/limit-reactions

Setting to limit reaction text length

Author: casperstorm

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Unreleased
 
+Added:
+
+- Setting to limit reaction text length (`buffer.channel.message.max_reaction_chars`)
+
 # 2026.4 (2026-03-03)
 
 Added:

Cargo.lock

@@ -5,6 +5,8 @@ Message settings within a channel buffer.
 - [Message](#message)
   - [Configuration](#configuration)
     - [nickname\_color](#nickname_color)
+    - [show\_emoji\_reacts](#show_emoji_reacts)
+    - [max\_reaction\_chars](#max_reaction_chars)
 
 ## Configuration
 
@@ -33,3 +35,17 @@ Whether to display emoji reactions on messages (if [IRCv3 React](https://ircv3.n
 [buffer.channel.message]
 show_emoji_reacts = true
 ```
+
+### max_reaction_chars
+
+Maximum number of user-visible characters (Unicode grapheme clusters) in a reaction.
+If a reaction exceeds this value, it is truncated to the first `max_reaction_chars` grapheme clusters.
+
+```toml
+# Type: integer
+# Values: positive integers
+# Default: 5
+
+[buffer.channel.message]
+max_reaction_chars = 5
+```

book/src/configuration/buffer/channel/message.md

@@ -31,6 +31,7 @@ tokio-stream = { workspace = true, features = ["time", "fs"] }
 timeago = { workspace = true }
 itertools = { workspace = true }
 emojis = { workspace = true }
+unicode-segmentation = { workspace = true }
 rand = { workspace = true }
 rand_chacha = { workspace = true }
 palette = { workspace = true }

data/Cargo.toml

@@ -19,13 +19,16 @@ pub struct Channel {
 pub struct Message {
     pub nickname_color: Color,
     pub show_emoji_reacts: bool,
+    #[serde(deserialize_with = "crate::serde::deserialize_positive_integer")]
+    pub max_reaction_chars: u32,
 }
 
 impl Default for Message {
     fn default() -> Self {
         Self {
             nickname_color: Color::default(),
             show_emoji_reacts: true,
+            max_reaction_chars: 5,
         }
     }
 }

data/src/config/buffer/channel.rs

@@ -1,6 +1,7 @@
 use chrono::{DateTime, Utc};
 use irc::proto::Command;
 use serde::{Deserialize, Serialize};
+use unicode_segmentation::UnicodeSegmentation;
 
 use crate::isupport;
 use crate::message::{Encoded, Id};
@@ -28,6 +29,7 @@ impl Reaction {
         chantypes: &[char],
         statusmsg: &[char],
         casemapping: isupport::CaseMap,
+        max_reaction_chars: u32,
     ) -> Option<Context> {
         let user = message.user(casemapping)?;
         let (text, unreact) = match (
@@ -38,6 +40,7 @@ impl Reaction {
             (None, Some(s)) => (s.clone(), true),
             _ => return None,
         };
+        let text = truncate_text(&text, max_reaction_chars as usize);
         let in_reply_to = message.in_reply_to()?;
         let server_time = message.server_time();
 
@@ -60,6 +63,18 @@ impl Reaction {
     }
 }
 
+pub fn truncate_text(text: &str, max_chars: usize) -> String {
+    if UnicodeSegmentation::graphemes(text, true).count() <= max_chars {
+        return text.to_string();
+    }
+
+    let mut truncated = UnicodeSegmentation::graphemes(text, true)
+        .take(max_chars)
+        .collect::<String>();
+    truncated.push_str("...");
+    truncated
+}
+
 #[derive(Debug)]
 pub struct Pending {
     pub reactions: Vec<Reaction>,
@@ -74,3 +89,38 @@ impl Pending {
         }
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::truncate_text;
+
+    #[test]
+    fn keeps_short_reaction_text() {
+        assert_eq!(truncate_text("hello", 5), "hello");
+    }
+
+    #[test]
+    fn truncates_ascii_to_limit() {
+        assert_eq!(truncate_text("hello world", 5), "hello...");
+    }
+
+    #[test]
+    fn truncates_unicode_graphemes() {
+        assert_eq!(truncate_text("cafe\u{301}", 4), "cafe\u{301}");
+    }
+
+    #[test]
+    fn limit_one_keeps_first_grapheme_when_truncated() {
+        assert_eq!(truncate_text("👍🏽👍🏽", 1), "👍🏽...");
+    }
+
+    #[test]
+    fn does_not_split_zwj_emoji_clusters() {
+        assert_eq!(truncate_text("👨‍👩‍👧‍👦x", 1), "👨‍👩‍👧‍👦...");
+    }
+
+    #[test]
+    fn does_not_split_combining_mark_clusters() {
+        assert_eq!(truncate_text("a\u{0301}b", 1), "a\u{0301}...");
+    }
+}

data/src/reaction.rs

@@ -1164,10 +1164,26 @@ impl State {
                 }
             }
             Message::Reacted { msgid, text } => {
-                send_reaction(clients, buffer, history, msgid, text, false);
+                send_reaction(
+                    clients,
+                    buffer,
+                    history,
+                    msgid,
+                    text,
+                    false,
+                    config.buffer.channel.message.max_reaction_chars,
+                );
             }
             Message::Unreacted { msgid, text } => {
-                send_reaction(clients, buffer, history, msgid, text, true);
+                send_reaction(
+                    clients,
+                    buffer,
+                    history,
+                    msgid,
+                    text,
+                    true,
+                    config.buffer.channel.message.max_reaction_chars,
+                );
             }
         }
         (Task::none(), None)
@@ -1394,8 +1410,10 @@ fn send_reaction(
     msgid: message::Id,
     text: String,
     unreact: bool,
+    max_reaction_chars: u32,
 ) -> Option<()> {
     let buffer = buffer?;
+    let text = reaction::truncate_text(&text, max_reaction_chars as usize);
     let server = buffer.server();
     let target = buffer.target()?;
     let command = match unreact {

src/buffer/scroll_view.rs

@@ -1558,6 +1558,7 @@ fn handle_client_events(
                     clients.get_chantypes(server),
                     clients.get_statusmsg(server),
                     clients.get_casemapping(server),
+                    config.buffer.channel.message.max_reaction_chars,
                 ) {
                     reactions.push(
                         dashboard