implement more comments

Author: notactuallyfinn

src/hermes/commands/deposit/base.py

@@ -154,5 +154,5 @@ def __call__(self, args: argparse.Namespace) -> None:
         except HermesValidationError as e:
             self.log.error(f"Error while executing {plugin_name}: {e}")
             raise HermesPluginRunError(
-                f"Something went wrong while running the curate plugin {self.settings.plugin}"
+                f"Something went wrong while running the deposit plugin {self.settings.plugin}"
             ) from e

src/hermes/commands/deposit/invenio.py

@@ -20,6 +20,7 @@
 from hermes.commands.deposit.error import DepositionUnauthorizedError
 from hermes.error import MisconfigurationError
 from hermes.model.error import HermesValidationError
+from hermes.model.types import ld_dict
 from hermes.utils import hermes_doi, hermes_user_agent
 
 
@@ -209,6 +210,9 @@ def resolve_license_id(self, license_url: Union[str, None]) -> Union[str, None]:
         if license_url is None:
             return None
 
+        if isinstance(license_url, (dict, ld_dict)) and [*license_url.keys()] == ["@id"]:
+            license_url = license_url["@id"]
+
         if not isinstance(license_url, str):
             raise RuntimeError(
                 "The given license in CodeMeta must be of type str. "

test/hermes_test/commands/deposit/test_invenio_e2e.py

@@ -37,7 +37,7 @@ def sandbox_auth():
                     "http://schema.org/familyName": [{"@value": "Test"}],
                     "http://schema.org/givenName": [{"@value": "Testi"}]
                 }],
-                "http://schema.org/license": ["https://spdx.org/licenses/Apache-2.0"]
+                "http://schema.org/license": [{"@id": "https://spdx.org/licenses/Apache-2.0"}]
             }),
             {
                 "upload_type": "software",