clean up

Author: notactuallyfinn

src/hermes/model/api.py

@@ -1,4 +1,4 @@
-from hermes.model.types import ld_dict, ld_list
+from hermes.model.types import ld_dict
 
 from hermes.model.types.ld_context import ALL_CONTEXTS
 
@@ -8,15 +8,3 @@ class SoftwareMetadata(ld_dict):
     def __init__(self, data: dict = None, extra_vocabs: dict[str, str] = None) -> None:
         ctx = ALL_CONTEXTS + [{**extra_vocabs}] if extra_vocabs is not None else ALL_CONTEXTS
         super().__init__([ld_dict.from_dict(data, context=ctx).data_dict if data else {}], context=ctx)
-
-    def add(self, key, value):
-        if key not in self:
-            self[key] = value
-            return
-        if isinstance(val := self[key], ld_list):
-            val.append(value)
-        else:
-            temp = ld_list([{"@list": []}], parent=self, key=self.ld_proc.expand_iri(self.active_ctx, key),
-                           context=self.context)
-            temp.extend([val, value])
-            self[key] = temp

test/hermes_test/model/test_api.py

@@ -60,7 +60,6 @@ def test_append():
     data["foo"].append("c")
     assert data["foo"].item_list == [{"@value": "a"}, {"@value": "b"}, {"@value": "c"}]
     data = SoftwareMetadata()
-    # FIXME: #433 will fix this
     data["foo"].append({"schema:name": "foo"})
     assert type(data["foo"]) is ld_list and type(data["foo"][0]) is ld_dict
     assert data["foo"][0].data_dict == {"http://schema.org/name": [{"@value": "foo"}]}
@@ -83,7 +82,6 @@ def test_iterative_assignment():
     author1["email"] = "author@example.com"
     authors[0] = author1
     authors.append({"name": "Bar", "email": "author2@example.com"})
-    data["author"] = authors
     assert len(authors) == 2