Skip to content

Commit d92c813

Browse files
committed
fix: correctly configure retain-artifacts: true/false on the event level, as it is parsed
1 parent a92ec11 commit d92c813

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

.test/config-sra/config.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,44 +47,44 @@ calling:
4747
moderate: "ANN['IMPACT'] == 'MODERATE'"
4848
no_filter: "True"
4949
fdr-control:
50-
threshold: 0.05
50+
threshold: 0.01
5151
# Denote FDR control mode.
5252
# The default (local-smart) is recommended because it provides the most realistic and intuitive results.
5353
# See see https://varlociraptor.github.io/docs/filtering for details.
5454
mode: local-smart
5555
# Retain artifacts upon FDR control (i.e. do not remove them from the callset,
5656
# see https://varlociraptor.github.io/docs/filtering)
5757
# Only applies in smart mode (local-smart or global-smart).
58-
retain-artifacts: false
5958
events:
6059
moderate:
60+
desc: Variants with moderate impact
6161
varlociraptor:
6262
- base_only
6363
- changed_only
6464
- both
6565
filter:
6666
- moderate
67-
desc: Variants with moderate impact
6867
present:
68+
desc: All variants present, unfiltered.
6969
varlociraptor:
7070
- base_only
7171
- changed_only
7272
- both
7373
filter:
7474
- no_filter
75-
desc: Variants with moderate impact
7675
present_or_artifact:
76+
desc: All variants present, unfiltered and with the artifacts probability also considered part of the present probability.
77+
retain-artifacts: true
7778
varlociraptor:
7879
- base_only
7980
- changed_only
8081
- both
81-
- artifact
8282
filter:
8383
- no_filter
84-
desc: Variants with moderate impact
8584

8685
complement_events:
8786
filtered_artifacts:
87+
desc: All variants that were removed from the present event during fdr control due to a high artifacts probability.
8888
report: True
8989
types: ["variants", "fusions"]
9090
full: present_or_artifact

config/config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,6 @@ calling:
150150
# The default (local-smart) is recommended because it provides the most realistic and intuitive results.
151151
# See see https://varlociraptor.github.io/docs/filtering for details.
152152
mode: local-smart
153-
# Retain artifacts upon FDR control (i.e. do not remove them from the callset,
154-
# see https://varlociraptor.github.io/docs/filtering)
155-
# Only applies in smart mode (local-smart or global-smart).
156-
retain-artifacts: false
157153
events:
158154
# Add any number of events here to filter for.
159155
# The id of each event can be chosen freely, but needs to contain
@@ -172,6 +168,10 @@ calling:
172168
# This will occur in the report.
173169
desc: |
174170
Some description.
171+
# Retain artifacts upon FDR control (i.e. do not remove them from the callset,
172+
# see https://varlociraptor.github.io/docs/filtering)
173+
# Only applies in smart mode (local-smart or global-smart).
174+
retain-artifacts: false
175175
varlociraptor:
176176
# Add varlociraptor events to aggregated over.
177177
# The probability for the union of these events is used for controlling

0 commit comments

Comments
 (0)