Skip to content

Commit 5cf5e75

Browse files
committed
Replace t.Fatalf with require in tests
AI disclosure: Claude Code assisted with development. Every line of code was either written by or carefully reviewed by me :) Signed-off-by: Brett Wines <bwines@slack-corp.com>
1 parent f152d3d commit 5cf5e75

1 file changed

Lines changed: 7 additions & 15 deletions

File tree

go/sync2/consolidator_test.go

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ import (
2121
"sync"
2222
"testing"
2323

24+
"github.com/stretchr/testify/require"
25+
2426
"vitess.io/vitess/go/sqltypes"
2527
)
2628

@@ -49,30 +51,20 @@ func TestAddWaiterCount(t *testing.T) {
4951
wgAdd.Wait()
5052
wgSub.Wait()
5153

52-
if con.TotalWaiterCount() != 0 {
53-
t.Fatalf("Expect 0 totalWaiterCount but got: %d", con.TotalWaiterCount())
54-
}
54+
require.Zero(t, con.TotalWaiterCount(), "expected 0 totalWaiterCount")
5555
}
5656

5757
func TestHasWaiters(t *testing.T) {
5858
con := NewConsolidator()
5959
sql := "select * from SomeTable"
6060

6161
orig, created := con.Create(sql)
62-
if !created {
63-
t.Fatalf("expected consolidator to register a new entry")
64-
}
65-
if orig.HasWaiters() {
66-
t.Fatalf("expected no waiters for a fresh entry")
67-
}
62+
require.True(t, created, "expected consolidator to register a new entry")
63+
require.False(t, orig.HasWaiters(), "expected no waiters for a fresh entry")
6864

6965
_, created = con.Create(sql)
70-
if created {
71-
t.Fatalf("did not expect consolidator to register a new entry")
72-
}
73-
if !orig.HasWaiters() {
74-
t.Fatalf("expected waiters after a duplicate Create")
75-
}
66+
require.False(t, created, "did not expect consolidator to register a new entry")
67+
require.True(t, orig.HasWaiters(), "expected waiters after a duplicate Create")
7668

7769
orig.SetResult(&sqltypes.Result{})
7870
orig.Broadcast()

0 commit comments

Comments
 (0)