fix(navigation): make kindToPlural idempotent on 'hpas' shortname

Bugbot HIGH: kindToPlural('hpas') was falling through to
englishPlural which appends 'es' (trailing s) → 'hpases', which
matched nothing in KNOWN_KINDS or the dispatch table. Since
ResourcesSidebar uses { kind: 'hpas' } as a primary key (the
dispatch even hard-codes 'hpas' || 'horizontalpodautoscalers' for
HPARenderer), clicking HPAs from the sidebar silently rendered
nothing — the same 'URL updates but no detail panel' regression
this PR set out to fix for CronJobs.

Add 'hpas' to BUILTIN_PLURAL_TO_KIND so kindToPlural('hpas')
hits the idempotence path and returns unchanged. Pin with a
regression test referencing the dispatch coupling.

Also: extract formatZoomLabel to packages/k8s-ui/src/utils/zoom-label.ts
so the test imports the production implementation instead of
duplicating it (the inline copy gave no regression protection).
TimelineSwimlanes re-exports from the new shared module.

Strip SKY-826 / bug-9 trailers from the renderer-dispatch comments
per CLAUDE.md (same pattern flagged on #584 / #572).

Made-with: Cursor

Author: eliran-mic

packages/k8s-ui/src/components/shared/ResourceRendererDispatch.tsx

@@ -354,17 +354,13 @@ export function ResourceRendererDispatch({
   resolvedEnvFrom,
   rendererOverrides,
 }: ResourceRendererDispatchProps) {
-  // Normalize the incoming `kind` to the lowercase plural form the
-  // dispatch table is keyed on. Without this, a caller that passes
-  // "CronJob" (PascalCase singular — e.g. from a topology node click,
-  // or any code path that hands the registry the singular kind name)
-  // produces `kind = 'cronjob'` after lowercasing, which doesn't
-  // match `'cronjobs'` and so silently renders nothing — the user
-  // saw the URL update but no detail panel. (SKY-826 bug 9)
-  //
-  // `kindToPlural` is idempotent: it returns already-plural inputs
-  // unchanged, so callers that already pass `'cronjobs'` are not
-  // double-pluralised.
+  // Callers reach this dispatch from two shapes: lowercase plural
+  // (resource list rows: 'cronjobs') and PascalCase singular
+  // (topology node clicks: 'CronJob'). The dispatch table is keyed
+  // only on lowercase plurals, so a raw .toLowerCase() leaves the
+  // singular form mismatched and nothing renders. kindToPlural
+  // covers both shapes idempotently (already-plural inputs return
+  // unchanged), so this single normalisation handles every caller.
   const kind = kindToPlural(resource.kind)
 
   const isKnownKind = KNOWN_KINDS.has(kind)
@@ -567,9 +563,8 @@ export function ResourceRendererDispatch({
 
 export function getResourceStatus(kind: string, data: any): { text: string; color: string } | null {
   if (!data) return null
-  // Normalise to lowercase plural for the same reason the renderer
-  // dispatch does — singular kinds like "CronJob" otherwise produce
-  // a no-match here too. (SKY-826 bug 9)
+  // Same normalisation as the renderer dispatch above — singular
+  // kinds like "CronJob" otherwise produce a no-match here too.
   const k = kindToPlural(kind)
 
   if (k === 'pods') return getPodStatus(data)

packages/k8s-ui/src/utils/navigation.test.ts

@@ -56,6 +56,19 @@ describe('kindToPlural', () => {
     expect(kindToPlural('horizontalpodautoscalers')).toBe('horizontalpodautoscalers')
   })
 
+  test('idempotent on dispatch-keyed shortnames (hpas)', () => {
+    // Bugbot regression for PR #585: ResourcesSidebar uses
+    // `{ kind: 'hpas' }` as a primary key (not a query alias) and the
+    // dispatch table at ResourceRendererDispatch matches both 'hpas'
+    // AND 'horizontalpodautoscalers'. Without an explicit entry in
+    // BUILTIN_PLURAL_TO_KIND, kindToPlural('hpas') falls through to
+    // englishPlural which sees a trailing 's' and adds 'es' →
+    // 'hpases', matching nothing. The detail panel then silently
+    // renders empty for HPAs — the exact CronJob-shaped bug this
+    // PR exists to prevent, just for a different kind. Pin it.
+    expect(kindToPlural('hpas')).toBe('hpas')
+  })
+
   test('handles aliases', () => {
     expect(kindToPlural('HorizontalPodAutoscaler')).toBe('horizontalpodautoscalers')
     expect(kindToPlural('pvc')).toBe('persistentvolumeclaims')

packages/k8s-ui/src/utils/navigation.ts

@@ -34,6 +34,13 @@ const BUILTIN_PLURAL_TO_KIND: Record<string, string> = {
   clusterrolebindings: 'ClusterRoleBinding',
   serviceaccounts: 'ServiceAccount',
   networkpolicies: 'NetworkPolicy',
+  // The codebase uses the kubectl shortname `hpas` as a *primary* dispatch
+  // key (see ResourcesSidebar `{ kind: 'hpas' }` and the dispatch table in
+  // ResourceRendererDispatch). Listing it here makes `kindToPlural('hpas')`
+  // return `'hpas'` unchanged via the idempotence check below — without
+  // this entry, `englishPlural('hpas')` adds "es" → `'hpases'` (ends in s)
+  // and the HPA detail panel renders nothing.
+  hpas: 'HorizontalPodAutoscaler',
 }
 
 // Dynamic map built from API discovery — populated by initNavigationMap().

packages/k8s-ui/src/utils/zoom-label.test.ts

@@ -1,24 +1,10 @@
 import { describe, it, expect } from 'vitest'
+import { formatZoomLabel } from './zoom-label'
 
-// Inline copy of the helper from web/src/components/timeline/TimelineSwimlanes.tsx
-// (same module — re-declared here to avoid pulling the swimlanes
-// React component into the unit-test boundary). If the rules drift,
-// update both. The shared rule it pins:
-//
-//   <  1h → "<m>m"
-//   <  24h → "<n>h"
-//   >= 24h → "<n>d"
-//
-// SKY-826 bug 12 turned a static "1h window" label into a real
-// dropdown of preset windows. The picker and the previous-render
-// label have to format identically or the user sees flicker between
-// "60m" (label) and "1h" (popover option) for the same zoom.
-function formatZoomLabel(zoom: number): string {
-  if (zoom < 1) return `${Math.round(zoom * 60)}m`
-  if (zoom >= 24) return `${Math.round(zoom / 24)}d`
-  return `${zoom}h`
-}
-
+// Pin the timeline-window label format. The picker and the
+// previous-render label MUST format identically or the user sees
+// flicker between "60m" (label) and "1h" (popover option) for the
+// same zoom.
 describe('formatZoomLabel (timeline window picker)', () => {
   it('formats sub-hour zooms as minutes', () => {
     expect(formatZoomLabel(0.25)).toBe('15m')
@@ -39,9 +25,7 @@ describe('formatZoomLabel (timeline window picker)', () => {
   })
 
   it('rounds (does not truncate) values at the bucket boundaries', () => {
-    // 0.49 * 60 = 29.4 → rounds to 29
     expect(formatZoomLabel(0.49)).toBe('29m')
-    // 35h / 24 = 1.458... → rounds to 1d (closer to 1 than 2)
     expect(formatZoomLabel(35)).toBe('1d')
   })
 })

packages/k8s-ui/src/utils/zoom-label.ts

@@ -0,0 +1,19 @@
+/**
+ * Format a zoom-window value (in hours) for display next to the
+ * timeline. Pure helper so the popover and the rest of the toolbar
+ * agree on the same string.
+ *
+ * Rules:
+ *   <  1h → "<m>m"
+ *   <  24h → "<n>h"
+ *   >= 24h → "<n>d"
+ *
+ * Lives in the shared utils package (not the web/ component file)
+ * so the unit test can import the production implementation
+ * directly instead of duplicating it.
+ */
+export function formatZoomLabel(zoom: number): string {
+  if (zoom < 1) return `${Math.round(zoom * 60)}m`
+  if (zoom >= 24) return `${Math.round(zoom / 24)}d`
+  return `${zoom}h`
+}

web/src/components/timeline/TimelineSwimlanes.tsx

@@ -173,21 +173,8 @@ function calculateInterestingnessWithBreakdown(lane: ResourceLane): ScoreBreakdo
   return breakdown
 }
 
-/**
- * Format a zoom-window value (in hours) for display next to the
- * timeline. Pure helper so the popover and the rest of the toolbar
- * agree on the same string. (SKY-826 bug 12)
- *
- * Rules:
- *   <  1h → "<m>m"
- *   <  24h → "<n>h"
- *   >= 24h → "<n>d"
- */
-export function formatZoomLabel(zoom: number): string {
-  if (zoom < 1) return `${Math.round(zoom * 60)}m`
-  if (zoom >= 24) return `${Math.round(zoom / 24)}d`
-  return `${zoom}h`
-}
+import { formatZoomLabel } from '@skyhook-io/k8s-ui/utils/zoom-label'
+export { formatZoomLabel }
 
 interface ZoomWindowPickerProps {
   zoom: number