[chore] reduce log output from passing tests (#37)

muir · web-flow · commit b5ea001d1a51 · 2025-06-27T08:08:18.000-07:00
The advantage of using `ntest.BufferedLogger()` over dropping `-v` from
`go test` is that we want to see which tests are skipped and `go test`
(no `-v`) doesn't show you what was skipped.
diff --git a/consumer_group_test.go b/consumer_group_test.go
@@ -108,7 +108,7 @@ func TestBroadcastGroupRefresh(t *testing.T) {
 	if os.Getenv("EVENTS_KAFKA_BROKERS") == "" {
 		t.Skipf("%s requires kafka brokers", t.Name())
 	}
-	ntest.RunTest(t,
+	ntest.RunTest(ntest.BufferedLogger(t),
 		CommonInjectors,
 		nject.Provide("nodb", func() *NoDB {
 			return nil // Pass nil connection to trigger no-database behavior
diff --git a/eventnodb/shared_test.go b/eventnodb/shared_test.go
@@ -52,7 +52,7 @@ func TestSharedEventNoDB(t *testing.T) {
 	if os.Getenv("EVENTS_KAFKA_BROKERS") == "" {
 		t.Skipf("%s requires kafka brokers", t.Name())
 	}
-	ntest.RunParallelMatrix(t,
+	ntest.RunParallelMatrix(ntest.BufferedLogger(t),
 		chain,
 		eventtest.GenerateSharedTestMatrix[eventmodels.BinaryEventID, *eventnodb.NoDBTx, *eventnodb.NoDB](),
 	)
diff --git a/eventpg/shared_test.go b/eventpg/shared_test.go
@@ -83,7 +83,7 @@ func pgconn(db *sql.DB) *DBType {
 type LibraryType = events.Library[eventmodels.StringEventID, *eventdb.ExampleBasicTX, *eventpg.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]]
 
 func TestSharedEventPG(t *testing.T) {
-	ntest.RunParallelMatrix(t,
+	ntest.RunParallelMatrix(ntest.BufferedLogger(t),
 		chain,
 		eventtest.GenerateSharedTestMatrix[eventmodels.StringEventID, *eventdb.ExampleBasicTX, *eventpg.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]](),
 	)
diff --git a/events2/shared_test.go b/events2/shared_test.go
@@ -104,15 +104,15 @@ func s2conn(db *sql.DB) *DBType {
 type LibraryType = events.Library[eventmodels.BinaryEventID, *eventdb.ExampleBasicTX, *events2.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]]
 
 func TestSharedEventS2(t *testing.T) {
-	ntest.RunParallelMatrix(t,
+	ntest.RunParallelMatrix(ntest.BufferedLogger(t),
 		chain,
 		eventtest.GenerateSharedTestMatrix[eventmodels.BinaryEventID, *eventdb.ExampleBasicTX, *events2.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]](),
 	)
 }
 
 func TestLockingLockOrDie(t *testing.T) {
 	t.Parallel()
-	ntest.RunTest(t, chain, func(
+	ntest.RunTest(ntest.BufferedLogger(t), chain, func(
 		t ntest.T,
 		ctx context.Context,
 		db *events2.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB],
diff --git a/go.mod b/go.mod
@@ -11,7 +11,7 @@ require (
 	github.com/lib/pq v1.10.9
 	github.com/memsql/errors v0.2.0
 	github.com/memsql/keyeddistributor v0.1.0
-	github.com/memsql/ntest v0.5.0
+	github.com/memsql/ntest v0.7.0
 	github.com/muir/gwrap v0.4.0
 	github.com/muir/libschema v0.6.1
 	github.com/muir/nject/v2 v2.1.0
diff --git a/go.sum b/go.sum
@@ -42,8 +42,8 @@ github.com/memsql/errors v0.2.0 h1:n1KKG0TRC0cqUmdropM9ygMDXbGORIN4HmbqU3y3SbM=
 github.com/memsql/errors v0.2.0/go.mod h1:82DslK+/CPzNprzYkjXk70ZHzzGCESIyv9PfH/hYcaQ=
 github.com/memsql/keyeddistributor v0.1.0 h1:JpouaTyKp8Q67vbcv/t6JCWWOazo2LQMf/S+yl0BMs4=
 github.com/memsql/keyeddistributor v0.1.0/go.mod h1:GD9Oam+jec0VPLp3fqKILCXTnykIGHK3crKtXS8Ju4Q=
-github.com/memsql/ntest v0.5.0 h1:FqS8XGLm0lzLKFdRXIl+hZw1FnPDvxCNB17TeBh2HZ8=
-github.com/memsql/ntest v0.5.0/go.mod h1:4qwQTVz/kYN+6tzgzkiDsWRucwCn2+KzCpwSsmWFt50=
+github.com/memsql/ntest v0.7.0 h1:I7DyHIvvCx+jGWEXQ1NOONng2BfhqCN3tBgLTu6ymJ8=
+github.com/memsql/ntest v0.7.0/go.mod h1:fRs4x6iD67RsQMra7lH2086F8Oi38WWkmNAo6B66T7s=
 github.com/memsql/refcountmap v0.1.1 h1:tcYPE9pRlVv7uwbDUY2E+sjhD/zBRRWvPQ0pz8IIujg=
 github.com/memsql/refcountmap v0.1.1/go.mod h1:kJR6RIBAI4iZgNo7hqQZZSmWWHNv+5t9X3RbOku86nk=
 github.com/muir/gwrap v0.4.0 h1:BfkdL6wxEv9Q7rdXoxz89+Wa65GZ9iNYPlCprL1sYXU=

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ func TestBroadcastGroupRefresh(t *testing.T) {`
`108`	`108`	`if os.Getenv("EVENTS_KAFKA_BROKERS") == "" {`
`109`	`109`	`t.Skipf("%s requires kafka brokers", t.Name())`
`110`	`110`	`}`
`111`		`- ntest.RunTest(t,`
	`111`	`+ ntest.RunTest(ntest.BufferedLogger(t),`
`112`	`112`	`CommonInjectors,`
`113`	`113`	`nject.Provide("nodb", func() *NoDB {`
`114`	`114`	`return nil // Pass nil connection to trigger no-database behavior`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ func TestSharedEventNoDB(t *testing.T) {`
`52`	`52`	`if os.Getenv("EVENTS_KAFKA_BROKERS") == "" {`
`53`	`53`	`t.Skipf("%s requires kafka brokers", t.Name())`
`54`	`54`	`}`
`55`		`- ntest.RunParallelMatrix(t,`
	`55`	`+ ntest.RunParallelMatrix(ntest.BufferedLogger(t),`
`56`	`56`	`chain,`
`57`	`57`	`eventtest.GenerateSharedTestMatrix[eventmodels.BinaryEventID, eventnodb.NoDBTx, eventnodb.NoDB](),`
`58`	`58`	`)`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ func pgconn(db sql.DB) DBType {`
`83`	`83`	`type LibraryType = events.Library[eventmodels.StringEventID, eventdb.ExampleBasicTX, eventpg.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]]`
`84`	`84`
`85`	`85`	`func TestSharedEventPG(t *testing.T) {`
`86`		`- ntest.RunParallelMatrix(t,`
	`86`	`+ ntest.RunParallelMatrix(ntest.BufferedLogger(t),`
`87`	`87`	`chain,`
`88`	`88`	`eventtest.GenerateSharedTestMatrix[eventmodels.StringEventID, eventdb.ExampleBasicTX, eventpg.Connection[*eventdb.ExampleBasicTX, eventdb.ExampleBasicDB]](),`
`89`	`89`	`)`