From 2b6fa8fdd022d0478c7edbe07b82455d33c4b309 Mon Sep 17 00:00:00 2001
From: Nick Weatherley <nick@shorebird.dev>
Date: Tue, 12 May 2026 09:43:51 -0400
Subject: [PATCH] debt(shorebird_cli): drop dead progress stub from account
 command tests

The `progress` field, `MockProgress` instantiation, and
`logger.progress(any())` stub were introduced in #3742 (orgs) and #3743
(apps) but never executed, because `codePushClientWrapper` is mocked at
the wrapper boundary, so the progress code inside the wrapper never
runs. Caught by bdero's review bot on #3743 and waived there as a
follow-up. This change closes that follow-up.
---
 .../test/src/commands/account/apps_command_test.dart           | 3 ---
 .../test/src/commands/account/orgs_command_test.dart           | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/packages/shorebird_cli/test/src/commands/account/apps_command_test.dart b/packages/shorebird_cli/test/src/commands/account/apps_command_test.dart
index f50e44dcf..1aa3ff9f8 100644
--- a/packages/shorebird_cli/test/src/commands/account/apps_command_test.dart
+++ b/packages/shorebird_cli/test/src/commands/account/apps_command_test.dart
@@ -37,7 +37,6 @@ void main() {
     late CodePushClientWrapper codePushClientWrapper;
     late ShorebirdValidator shorebirdValidator;
     late ShorebirdLogger logger;
-    late Progress progress;
     late AppsCommand command;
 
     R runWithOverrides<R>(R Function() body) {
@@ -56,11 +55,9 @@ void main() {
       argResults = MockArgResults();
       codePushClientWrapper = MockCodePushClientWrapper();
       logger = MockShorebirdLogger();
-      progress = MockProgress();
       shorebirdValidator = MockShorebirdValidator();
       command = runWithOverrides(AppsCommand.new)..testArgResults = argResults;
 
-      when(() => logger.progress(any())).thenReturn(progress);
       when(() => argResults.rest).thenReturn([]);
       when(
         () => shorebirdValidator.validatePreconditions(
diff --git a/packages/shorebird_cli/test/src/commands/account/orgs_command_test.dart b/packages/shorebird_cli/test/src/commands/account/orgs_command_test.dart
index ca3d6587e..69ebda403 100644
--- a/packages/shorebird_cli/test/src/commands/account/orgs_command_test.dart
+++ b/packages/shorebird_cli/test/src/commands/account/orgs_command_test.dart
@@ -43,7 +43,6 @@ void main() {
     late CodePushClientWrapper codePushClientWrapper;
     late ShorebirdValidator shorebirdValidator;
     late ShorebirdLogger logger;
-    late Progress progress;
     late OrgsCommand command;
 
     R runWithOverrides<R>(R Function() body) {
@@ -62,11 +61,9 @@ void main() {
       argResults = MockArgResults();
       codePushClientWrapper = MockCodePushClientWrapper();
       logger = MockShorebirdLogger();
-      progress = MockProgress();
       shorebirdValidator = MockShorebirdValidator();
       command = runWithOverrides(OrgsCommand.new)..testArgResults = argResults;
 
-      when(() => logger.progress(any())).thenReturn(progress);
       when(() => argResults.rest).thenReturn([]);
       when(
         () => shorebirdValidator.validatePreconditions(