Rule constructor no-reflection used test (#359)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: xificurk

composer.json

@@ -11,7 +11,7 @@
     ],
     "require": {
         "php": "^7.4 || ^8.0",
-        "phpstan/phpstan": "^2.1.32"
+        "phpstan/phpstan": "^2.1.33"
     },
     "require-dev": {
         "editorconfig-checker/editorconfig-checker": "^10.6.0",

composer.lock

@@ -0,0 +1,3 @@
+services:
+    betterReflectionSourceLocator:
+        class: ShipMonk\PHPStan\ThrowingSourceLocator

tests/NoReflectionInRuleConstructorTest.neon

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace ShipMonk\PHPStan;
+
+use PHPStan\Testing\PHPStanTestCase;
+use function array_merge;
+
+class NoReflectionInRuleConstructorTest extends PHPStanTestCase
+{
+
+    /**
+     * @return string[]
+     */
+    public static function getAdditionalConfigFiles(): array
+    {
+        return array_merge(
+            parent::getAdditionalConfigFiles(),
+            [
+                __DIR__ . '/../rules.neon',
+                __DIR__ . '/NoReflectionInRuleConstructorTest.neon',
+            ],
+        );
+    }
+
+    public function test(): void
+    {
+        self::expectNotToPerformAssertions();
+
+        self::getContainer()->getServicesByTag('phpstan.rules.rule');
+    }
+
+}

tests/NoReflectionInRuleConstructorTest.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace ShipMonk\PHPStan;
+
+use LogicException;
+use PHPStan\BetterReflection\Identifier\Identifier;
+use PHPStan\BetterReflection\Identifier\IdentifierType;
+use PHPStan\BetterReflection\Reflection\Reflection;
+use PHPStan\BetterReflection\Reflector\Reflector;
+use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
+
+class ThrowingSourceLocator implements SourceLocator
+{
+
+    public function locateIdentifier(
+        Reflector $reflector,
+        Identifier $identifier
+    ): ?Reflection // @phpstan-ignore return.internalInterface
+    {
+        throw new LogicException('Reflection must not be called during rule construction');
+    }
+
+    /**
+     * @return list<Reflection>
+     */
+    public function locateIdentifiersByType(
+        Reflector $reflector,
+        IdentifierType $identifierType
+    ): array // @phpstan-ignore return.internalInterface
+    {
+        throw new LogicException('Reflection must not be called during rule construction');
+    }
+
+}