Since we now have full URI support in okio-extras, which can even decode URL-encoded sequences like %D0%A2%D0%B5%D1%81%D1%82, there's no need for simple heuristics like String.dropFileProtocol() and Path.adaptedIsAbsolute().
In addition to mere refactoring (which should be simple), extra steps should be made:
Current test coverage doesn't seem enough.
Since we now have full URI support in
okio-extras, which can even decode URL-encoded sequences like%D0%A2%D0%B5%D1%81%D1%82, there's no need for simple heuristics likeString.dropFileProtocol()andPath.adaptedIsAbsolute().In addition to mere refactoring (which should be simple), extra steps should be made:
pylint(pylint --output-format=sarif --disable=... --enable=... --output xyz.sarif) etc. Apparently,urianduriBaseIdfields may contain bothfile://URIs and local paths, absolute or relative.uriand/oruriBaseIdcontain unparseable garbage. The library should handle these cases gracefully, in a predictable and well-documented manner.Current test coverage doesn't seem enough.