[Bug]: Declaration of Coolsam\Modules\Commands\ModuleMakeFilamentThemeCommand::handle(): int must be compatible

[Amirali-Bagheri]

What happened?

What happened?
When attempting to use the module:make:filament-theme command, a Symfony\Component\ErrorHandler\Error\FatalError occurs, indicating an incompatibility in the handle method signature. Specifically, Coolsam\Modules\Commands\ModuleMakeFilamentThemeCommand::handle(): int is not compatible with Filament\Commands\MakeThemeCommand::handle(Illuminate\Filesystem\Filesystem $filesystem): int.

The error message points to vendor/coolsam/modules/src/Commands/ModuleMakeFilamentThemeCommand.php on line 18.

Symfony\Component\ErrorHandler\Error\FatalError

Declaration of Coolsam\Modules\Commands\ModuleMakeFilamentThemeCommand::handle(): int must be compatible with Filament\Commands\MakeThemeCommand::handle(Illuminate\Filesystem\Filesystem $filesystem): int

at vendor/coolsam/modules/src/Commands/ModuleMakeFilamentThemeCommand.php:18
14▕ protected $signature = 'module:make:filament-theme {module?} {--pm=} {--F|force}';
15▕
16▕ protected $description = 'Create a new Filament theme in a module';
17▕
➜ 18▕ public function handle(): int
19▕ {
20▕ $module = $this->getModule();
21▕
22▕ $this->call('vendor:publish', [What did you expect to happen?
I expected the composer dump-autoload command to execute successfully without any method signature compatibility errors, and for the application's autoloading to be regenerated correctly.

How to reproduce the bug

1. Ensure you have the coolsam/modules package installed in your Laravel project.
2. Attempt to run the command in your terminal:
   composer dump-autoload
   When I do X I see Y.
   When I run composer dump-autoload, I encounter the FatalError regarding the handle method's signature incompatibility as detailed above.

I expected the composer dump-autoload command to execute successfully without any method signature compatibility errors, and for the application's autoloading to be regenerated correctly.
How to reproduce the bug
Ensure you have the coolsam/modules package installed in your Laravel project.
Attempt to run the command in your terminal:

composer dump-autoload

How to reproduce the bug

When I run composer dump-autoload, I encounter the FatalError regarding the handle method's signature incompatibility as detailed above.

Package Version

5.0.8

PHP Version

8.4

Laravel Version

12

Which operating systems does with happen with?

macOS

Notes

No response

[KleinDevDE]

I can confirm this issue

Cause

Filament (and also the MakeThemeCommand class) got updated last week. v4.3.0 => v4.3.1
See: filamentphp/filament@029f358

System info

OS: Linux Mint 22
PHP Version: 8.4.15

Package versions

package	version
coolsam/modules	v5.0.8
filament/filaments	v4.3.1
laravel/framework	v12.42.0
nwidart/laravel-modules	v12.0.4

Workaround

Downgrade Filament to v4.3.0, after the downgrade it works again.
Please make sure to upgrade again once filament-modules supports Filament ≥ 4.3.1.
This is only a temporary pin to avoid compatibility issues.

My composer.json

        "filament/actions": "4.3.0",
        "filament/forms": "4.3.0",
        "filament/infolists": "4.3.0",
        "filament/notifications": "4.3.0",
        "filament/schemas": "4.3.0",
        "filament/tables": "4.3.0",
        "filament/widgets": "4.3.0",

Note

There is already a Pull-Request to theoretically fix this issue (haven't tested it out myself yet).
#159

[yaman3bd]

I get the same error after I run: composer require coolsam/modules:

 | composer require coolsam/modules

./composer.json has been updated
Running composer update coolsam/modules
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 0 removals
  - Locking coolsam/modules (v5.0.9)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing coolsam/modules (v5.0.9): Extracting archive
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   Symfony\Component\ErrorHandler\Error\FatalError

  Declaration of Coolsam\Modules\Commands\ModuleMakeFilamentThemeCommand::handle(Illuminate\Filesystem\Filesystem $filesystem): int must be compatible with Filament\Commands\MakeThemeCommand::handle(): int

  at vendor/coolsam/modules/src/Commands/ModuleMakeFilamentThemeCommand.php:19
     15▕     protected $signature = 'module:make:filament-theme {module?} {--pm=} {--F|force}';
     16▕
     17▕     protected $description = 'Create a new Filament theme in a module';
     18▕
  ➜  19▕     public function handle(Filesystem $filesystem): int
     20▕     {
     21▕         $module = $this->getModule();
     22▕
     23▕         $this->call('vendor:publish', [


   Whoops\Exception\ErrorException

  Declaration of Coolsam\Modules\Commands\ModuleMakeFilamentThemeCommand::handle(Illuminate\Filesystem\Filesystem $filesystem): int must be compatible with Filament\Commands\MakeThemeCommand::handle(): int

  at vendor/coolsam/modules/src/Commands/ModuleMakeFilamentThemeCommand.php:19
     15▕     protected $signature = 'module:make:filament-theme {module?} {--pm=} {--F|force}';
     16▕
     17▕     protected $description = 'Create a new Filament theme in a module';
     18▕
  ➜  19▕     public function handle(Filesystem $filesystem): int
     20▕     {
     21▕         $module = $this->getModule();
     22▕
     23▕         $this->call('vendor:publish', [

      +1 vendor frames

  2   [internal]:0
      Whoops\Run::handleShutdown()

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255

My composer.json:

{
    "php": "PHP 8.4.10"
    "Laravel Framework": "12.33.0",
    "filament/filament": "^4.0",
    "nwidart/laravel-modules": "^12.0",
}