Make ArrayViewMut::into_view public to allow lifetime preservation during conversion#1600
Merged
akern40 merged 2 commits intoJun 19, 2026
Merged
Conversation
…st-ndarray#1595) - Change ArrayViewMut::into_view visibility to pub - Add From<ArrayViewMut> for ArrayView implementation - Add regression tests in tests/views.rs
Collaborator
|
Thanks. Can you please fix the failing cicd checks? |
Collaborator
|
Lgtm, thanks again. I prefer to wait for the principal maintainer @akern40 to merge this. Shouldn't take too long. |
Contributor
Author
OK @nilgoyette thanks for review |
Collaborator
|
Seems sound to me, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1595.
Currently, ArrayViewMut lacks a public API to convert to ArrayView while preserving the lifetime 'a. This PR makes
into_view
public to allow consuming the mutable view into a shared one without lifetime truncation.
src/impl_views/conversions.rs
: Make
into_view
public
src/arraytraits.rs
: Implement From for ArrayView
tests/views.rs
: Add regression tests for struct-wrapped conversions