test(chore): audit //@ run-pass in ui tests#154254
Conversation
//@ run-pass in ui tests//@ run-pass in ui tests
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@rustbot reroll |
|
Thank you. Could you let me know when you're ready with @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d865e9d to
a85f929
Compare
This comment has been minimized.
This comment has been minimized.
Assisted-by: OpenAI:gpt-5.5 Co-authored-by: Ayuse <ayodeleoluwasina@gmail.com> Signed-off-by: Embers-of-the-Fire <stellarishs@163.com>
a85f929 to
296a847
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot review |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@Embers-of-the-Fire Could you fix CI failures? |
|
@TaKO8Ki Most of the errors (at least those I could observe) originate from linter warnings, and I'm not sure if you want me to fix them by 1) switching back to |
|
@Embers-of-the-Fire These look like stale stderr expectations after the mode change. The actual output is empty, I guess. You can keep |
|
☔ The latest upstream changes (presumably #156506) made this pull request unmergeable. Please resolve the merge conflicts. |
Part of work for #154158. The list is non-exhausive and there's definitely parts that I can/will not cover.
Note: still working here with around ~1000 tests to audit and finished ~400 files. Do not merge this but could be reviewed now :)