Auto import always top of file

[curtispuetz]

Sometimes in VSCode the rust-analyzer puts my auto-import in the function I am working in rather than at the top of the file. I always want them to be at the top of the file, and I don't believe there is a rust-analyzer setting to configure this, as I played with the available import settings.

So, the desired feature is: auto-import always to the top of file

[A4-Tacks]

If the function is conditionally compiled (#[cfg()]), placing it in the function can avoid unused imports

[curtispuetz]

If the function is conditionally compiled (#[cfg()]), placing it in the function can avoid unused imports

That is true, but in my case, it's not conditionally compiled, and it's annoying to have to cut it to the top of the file. A setting to enable always to the top of the file would be nice.

[A4-Tacks]

but in my case, it's not conditionally compiled

Can you provide a reproduction?

[curtispuetz]

but in my case, it's not conditionally compiled

Can you provide a reproduction?

The best I can just say is that it's happening inside my integration test functions. This is my test code:

use rstest::rstest;
use rstest_reuse::{apply, template};

use game_server::c::{
    database::card_ids::{BONE_CRUSHER_ID, BONE_MENDER_ID},
    msgs::{client::messages::ClientMsg, server::messages::InvalidAction},
};

use crate::process_events::c::{
    assertion_helpers::assert_invalid_action,
    setup_helpers::{process_events_a, state_with_cards},
};
use crate::{
    c::macros::rstest_cases,
    process_events::c::constants::{
        AFTER_WEAPON_ENEMY_ALLY_TARGET, AFTER_WEAPON_FRIENDLY_ALLY_TARGET,
    },
};
use game_server::c::database::card_ids::TRIAD_OF_POWER_ID;

use crate::process_events::c::constants::PLAY_SPELL;
use crate::process_events::c::setup_helpers::process_events_multiple_a;

rstest_cases!(_all_msgs, [card_id: u16, client_msg: ClientMsg], [
    friendly_ally_target => (BONE_MENDER_ID, AFTER_WEAPON_FRIENDLY_ALLY_TARGET),
    enemy_ally_target => (BONE_CRUSHER_ID, AFTER_WEAPON_ENEMY_ALLY_TARGET),
]);

#[apply(_all_msgs)]
pub fn not_waiting_for_action(_card_id: u16, client_msg: ClientMsg) {
    let state = state_with_cards(vec![], vec![]);
    let (result, _) = process_events_a(state, client_msg);
    assert_invalid_action(result, InvalidAction::NotWaitingForAction);
}

#[apply(_all_msgs)]
pub fn not_waiting_for_after_weapon(_card_id: u16, client_msg: ClientMsg) {
    let state = state_with_cards(vec![TRIAD_OF_POWER_ID], vec![]);
    let (result, _) = process_events_multiple_a(state, vec![PLAY_SPELL, client_msg]);
    assert_invalid_action(result, InvalidAction::NotWaitingForAfterWeapon);
}

And the macro:

macro_rules! rstest_cases {
    ($name:ident, [$($param:ident: $type:ty),+ $(,)?], [$($case_name:ident => ($($args:tt)*)),+ $(,)?]) => {
        #[template]
        #[rstest]
        $( #[case::$case_name($($args)*)] )+
        fn $name($( #[case] $param: $type ),+) {}
    };
}

[ChayimFriedman2]

Without a full reproduction, there isn't much we can do other than saying "this should not happen".

However, are you sure the #[apply] proc macro does not add some cfg?

[curtispuetz]

Without a full reproduction, there isn't much we can do other than saying "this should not happen".

However, are you sure the #[apply] proc macro does not add some cfg?

I am not 100% sure about that. But it doesn't matter, because:

I think you've misunderstood the purpose of this issue. This is a feature request asking to have a flag to always put the imports on the top of the file, regardless of the situation. It's not a bug report saying that: it should have been put on top of the file in my situation, but it's not. It's not a bug report.

The feature request makes sense and is something some people will use. I can assure you that in my test code, it is desired to put the imports on top of the file. There is no way I would want to put a bunch of includes inside each function. It could be low hanging fruit too. That's why the feature makes sense. It's something I wish I had.

The question is whether your project wants to plan to do it. That's your decision.

[ChayimFriedman2]

As a feature request this is reasonable, however you seem to want it only for test code. If that is true, then I don't think we should have that.

[curtispuetz]

As a feature request this is reasonable, however you seem to want it only for test code. If that is true, then I don't think we should have that.

I didn't say anywhere that I only want it for test code. A config flag to have import always at the top of the file I would like.

[ChayimFriedman2]

I didn't say anywhere that I only want it for test code.

I can assure you that in my test code, it is desired to put the imports on top of the file.

But I might have misunderstood.