validates_uniqueness_of does not use "where deleted_at is null"

[codeodor]

It's trivial in Rails 4 for the client code to fix by adding :conditions but that's not an option in Rails 3.

Is there any interest in a fix for this, either by adding a new method (maybe append _without_deleted to the name, or fixing it to work to be consistent with the rest of the queries it modifies?

[radar]

@codeodor Can you show me a situation with this failing?

[codeodor]

Sure, I added tests to each branch that show it failing.

Employer has a new column name on which we use validates_uniqueness_of in the model.

The test creates a record, destroys it, and creates a new instance with the same name, and asserts whether the record is valid. At present, it is not.

[kidlab]

I encountered this problem too.
Here is my models:

class User < ActiveRecord::Base
  acts_as_paranoid

  has_many :favorites, dependent: :destroy
end

class Book < ActiveRecord::Base
  acts_as_paranoid

  has_many :favorites, dependent: :destroy
end

class Favorite < ActiveRecord::Base
  acts_as_paranoid

  belongs_to :user
  belongs_to :book

  validates :user, :book, presence: true
  validates_uniqueness_of :book_id, scope: :user_id
end

This code below will add book to user's favorite then remove it by soft-deleting. After that I cannot add book to favorite any more, because validates_uniqueness_of :book_id, scope: :user_id does not use paranoid scope.

user = User.first
book = Book.first

# Add my favorite book
f = Favorite.create(user: user, book: book)
# => #<Favorite id: 1, user_id: 1, book_id: 1, deleted_at: nil, created_at: "2014-03-15 17:53:50", updated_at: "2014-03-15 17:53:50">

# Remove from favorite
f.destroy

# Re-add book to favorite
f = Favorite.new(user: user, book: book)
f.valid?
# => false

f.errors
# => #<ActiveModel::Errors:0x007f2a8922acf8 @base=#<Favorite id: nil, user_id: 1, book_id: 1, deleted_at: nil, created_at: nil, updated_at: nil>, @messages={:book_id=>["has already been taken"]}>

[smostovoy]

+1. https://github.com/goncalossilva/acts_as_paranoid has validates_uniqueness_of_without_deleted. IMHO it should be default. @radar do you plan anything?

[codeodor]

@radar I added fixes to the rails3 and rails4 branches (of my fork, and thus the pull requests I made) where I had previously only included failing tests.

I am not sure how you feel about it, but I don't really like the idea of validates_uniqueness_of_without_deleted since the rest of the gem operates transparently.

Because of that, I used alias_method_chain to call the build_relation method both Rails 3 and 4 call when finding the existing records, and made sure we add relation.and(klass.quoted_table_name + ".#{klass.paranoia_column} IS NULL") to the relation. That fixes the tests.

[codeodor]

FWIW, I looked into the Rails4 branch failure on Travis CI. One is due to (I think) assert_nothing_raised being gone on the Rails 4.1 tests. I have no idea why the 4.0.2 test is failing -- It works for me locally on 1.9.3 and 2.0.0.

I'm not sure if that's something I broke, or if it's been broken for a while.

[dvdplm]

Any updates on this? :/

[dvdplm]

PR on the PR: codeodor#1

[codeodor]

Thanks, merged it into mine.

[radar]

Is there any interest in getting that PR merged back here? If so, please submit it as a PR.