[Fix][SDK-436] Expo crash on init (#209)

* fix: add missing init call to Rollbar Android

* fix: prevent future NPEs, fail silently

* refactor: remove initialization of Native notifier when RollbarReactNative is created

* ci: add workflow to run Android tests

* build: set explicit dependencies versions and add test libraries

* test: add tests

* ci: modify target branch

* ci: remove install npm dependencies step

* ci: remove android working directory

---------

Co-authored-by: chris <christian.buongarzoni@gmail.com>

Author: buongarzoni

.github/workflows/android_unit_tests.yml

@@ -0,0 +1,36 @@
+name: Android Unit Tests
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    name: Run Java Unit Tests
+    runs-on: ubuntu-latest
+
+    env:
+      CI: true
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+
+      - name: Set up JDK 11
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: '18'
+
+      - name: Make Gradle executable
+        run: chmod +x ./gradlew
+
+      - name: Run unit tests
+        run: ./gradlew test

android/build.gradle

@@ -14,6 +14,10 @@ android {
 
 dependencies {
     implementation('com.rollbar:rollbar-android:1.7.1')
-    implementation 'com.facebook.react:react-native:+'
-    implementation 'com.google.code.gson:gson:+'
+    implementation 'com.facebook.react:react-android:0.71.0'
+    implementation 'com.google.code.gson:gson:2.9.0'
+
+    testImplementation 'junit:junit:4.13.2'
+    testImplementation 'org.mockito:mockito-core:3.8.0'
+    testImplementation 'org.mockito:mockito-inline:3.8.0'
 }

android/src/main/java/com/rollbar/RollbarReactNative.java

@@ -525,12 +525,16 @@ public String getName() {
 
   @ReactMethod
   public void init(ReadableMap options) {
+    Rollbar rollbar = Rollbar.instance();
+    if (rollbar == null) {
+      return;
+    }
     final String environment = options.hasKey("environment") ? options.getString("environment") : "production";
     final String platform = options.hasKey("platform") ? options.getString("platform") : "android";
     final String notifier_version = options.hasKey("notifier") ? options.getMap("notifier").getString("version") : NOTIFIER_VERSION;
     final String notifier_name = options.hasKey("notifier") ? options.getMap("notifier").getString("name") : NOTIFIER_NAME;
     final boolean enabled = options.hasKey("enabled") ? options.getBoolean("enabled") : true;
-    Rollbar.instance().configure(new ConfigProvider() {
+    rollbar.configure(new ConfigProvider() {
       @Override
       public Config provide(ConfigBuilder builder) {
         return builder

android/src/test/java/com/rollbar/RollbarReactNativeTest.java

@@ -0,0 +1,69 @@
+package com.rollbar;
+
+import android.content.pm.ApplicationInfo;
+import android.content.pm.PackageManager;
+import android.content.pm.PackageManager.NameNotFoundException;
+import android.util.Log;
+import com.facebook.react.bridge.ReactApplicationContext;
+import com.facebook.react.bridge.ReadableMap;
+
+import java.util.HashMap;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.MockedStatic;
+
+import static org.mockito.Mockito.*;
+import static org.junit.Assert.*;
+
+public class RollbarReactNativeTest {
+
+  private ApplicationInfo mockedApplicationInfo;
+  private PackageManager mockedPackageManager;
+  private RollbarReactNative rollbarModule;
+  private ReactApplicationContext mockedContext;
+  private ReadableMap mockedReadableMap;
+
+  @Before
+  public void setUp() {
+    mockedContext = mock(ReactApplicationContext.class);
+    mockedReadableMap = mock(ReadableMap.class);
+    mockedPackageManager = mock(PackageManager.class);
+    mockedApplicationInfo = mock(ApplicationInfo.class);
+    rollbarModule = new RollbarReactNative(mockedContext);
+  }
+
+  @Test
+  public void configUpdateDoNothingWhenNativeNotifierIsNotInitialized() {
+    try (MockedStatic<Log> mockedLog = mockStatic(Log.class)) {
+
+      rollbarModule.init(mockedReadableMap);
+
+      mockedLog.verify(() -> Log.w("Rollbar", "Attempt to access Rollbar.instance() before initialization."));
+    }
+  }
+
+  @Test
+  public void configUpdateSuccessfulWhenNativeNotifierIsInitialized() throws NameNotFoundException {
+    try (MockedStatic<Log> mockedLog = mockStatic(Log.class)) {
+      initNativeNotifier();
+
+      rollbarModule.init(mockedReadableMap);
+
+      mockedLog.verify(never(), () -> Log.w("Rollbar", "Attempt to access Rollbar.instance() before initialization."));
+    }
+  }
+
+  private void initNativeNotifier() throws NameNotFoundException {
+    when(mockedContext.getPackageManager())
+        .thenReturn(mockedPackageManager);
+
+    when(mockedContext.getPackageName())
+        .thenReturn("any");
+
+    when(mockedPackageManager.getApplicationInfo("any", PackageManager.GET_META_DATA))
+        .thenReturn(mockedApplicationInfo);
+
+    RollbarReactNative.init(mockedContext, "Any token", "Any environment");
+  }
+
+}

build.gradle

@@ -0,0 +1,16 @@
+buildscript {
+    repositories {
+        google()
+        mavenCentral()
+    }
+    dependencies {
+        classpath 'com.android.tools.build:gradle:4.2.2'
+    }
+}
+
+allprojects {
+    repositories {
+        google()
+        mavenCentral()
+    }
+}

gradle.properties

@@ -0,0 +1 @@
+android.useAndroidX=true

gradle/wrapper/gradle-wrapper.jar

@@ -0,0 +1,5 @@
+distributionBase=GRADLE_USER_HOME
+distributionPath=wrapper/dists
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.4-bin.zip
+zipStoreBase=GRADLE_USER_HOME
+zipStorePath=wrapper/dists