Skip to content

Commit 0df5f45

Browse files
authored
Merge pull request #185 from rollbar/fixed/phpunit-tests-failing
Fixed failing PHPUnit tests
2 parents 6154e84 + bf118ff commit 0df5f45

5 files changed

Lines changed: 31 additions & 9 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ composer.lock
33
.DS_Store
44
.idea
55
.vscode
6-
.phpunit.result.cache
6+
.phpunit.cache

phpunit.xml

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
34
bootstrap="tests/bootstrap.php"
4-
colors="true"
5-
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd">
6-
<coverage>
5+
cacheDirectory=".phpunit.cache"
6+
executionOrder="depends,defects"
7+
requireCoverageMetadata="true"
8+
beStrictAboutCoverageMetadata="true"
9+
beStrictAboutOutputDuringTests="true"
10+
displayDetailsOnPhpunitDeprecations="true"
11+
failOnPhpunitDeprecation="true"
12+
failOnRisky="true"
13+
failOnWarning="true">
14+
<source restrictNotices="true" restrictWarnings="true">
715
<include>
816
<directory suffix=".php">./src</directory>
917
</include>
10-
</coverage>
18+
</source>
1119
<testsuites>
1220
<testsuite name="Test Suite">
13-
<directory suffix=".php">./tests/</directory>
21+
<directory suffix="Test.php">./tests/</directory>
1422
</testsuite>
1523
</testsuites>
1624
</phpunit>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use Mockery;
77
use Rollbar\Laravel\RollbarServiceProvider;
88

9-
abstract class TestCase extends \Orchestra\Testbench\TestCase
9+
abstract class AbstractTestCase extends \Orchestra\Testbench\TestCase
1010
{
1111
protected string $access_token = 'B42nHP04s06ov18Dv8X7VI4nVUs6w04X';
1212

tests/RollbarTest.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,19 @@
22

33
namespace Rollbar\Laravel\Tests;
44

5+
use PHPUnit\Framework\Attributes\CoversClass;
6+
use PHPUnit\Framework\Attributes\UsesClass;
57
use Rollbar\Laravel\MonologHandler;
68
use Rollbar\Laravel\AgentHandler;
9+
use Rollbar\Laravel\RollbarServiceProvider;
10+
use Rollbar\Laravel\TelemetryListener;
711
use Rollbar\RollbarLogger;
812

9-
class RollbarTest extends TestCase
13+
#[UsesClass(AgentHandler::class)]
14+
#[UsesClass(MonologHandler::class)]
15+
#[UsesClass(TelemetryListener::class)]
16+
#[CoversClass(RollbarServiceProvider::class)]
17+
class RollbarTest extends AbstractTestCase
1018
{
1119
public function testBinding()
1220
{

tests/TelemetryListenerTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,16 @@
88
use Illuminate\Log\Events\MessageLogged;
99
use Illuminate\Routing\Events\RouteMatched;
1010
use Illuminate\Routing\Route;
11+
use PHPUnit\Framework\Attributes\CoversClass;
12+
use PHPUnit\Framework\Attributes\UsesClass;
13+
use Rollbar\Laravel\RollbarServiceProvider;
14+
use Rollbar\Laravel\TelemetryListener;
1115
use Rollbar\Rollbar;
1216
use Rollbar\Telemetry\EventLevel;
1317

14-
class TelemetryListenerTest extends TestCase
18+
#[UsesClass(RollbarServiceProvider::class)]
19+
#[CoversClass(TelemetryListener::class)]
20+
class TelemetryListenerTest extends AbstractTestCase
1521
{
1622
protected function setUp(): void
1723
{

0 commit comments

Comments
 (0)