test untested File functions (#371)

Anton-4 · web-flow · commit 4ca7ff1e0c71 · 2025-05-31T20:27:29.000+02:00
* test untested file funcs

* typo
diff --git a/ci/expect_scripts/bytes-stdin-stdout.exp b/ci/expect_scripts/bytes-stdin-stdout.exp
@@ -17,5 +17,5 @@ expect "someinput\r\nsomeinput\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/command-line-args.exp b/ci/expect_scripts/command-line-args.exp
@@ -20,5 +20,5 @@ expect "received argument: foo\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/command.exp b/ci/expect_scripts/command.exp
@@ -16,5 +16,5 @@ expect -exact "EXEC\r\nFOO=BAR\r\nBAZ=DUCK\r\nFOO=BAR\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/dir.exp b/ci/expect_scripts/dir.exp
@@ -15,5 +15,5 @@ expect "Success!\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/env-var.exp b/ci/expect_scripts/env-var.exp
@@ -21,5 +21,5 @@ expect "Your favorite editor is nano!\r\n" {
         }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/env.exp b/ci/expect_scripts/env.exp
@@ -57,5 +57,5 @@ expect "Testing Env module functions..." {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/error-handling.exp b/ci/expect_scripts/error-handling.exp
@@ -15,5 +15,5 @@ expect "NotFound\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/file-accessed-modified-created-time.exp b/ci/expect_scripts/file-accessed-modified-created-time.exp
@@ -21,5 +21,5 @@ expect {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/file-permissions.exp b/ci/expect_scripts/file-permissions.exp
@@ -15,5 +15,5 @@ expect "LICENSE file permissions:\r\n    Executable: Bool.false\r\n    Readable:
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/file-read-buffered.exp b/ci/expect_scripts/file-read-buffered.exp
@@ -15,5 +15,5 @@ expect "Done reading file: {bytes_read: 1915, lines_read: 17}\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/file-size.exp b/ci/expect_scripts/file-size.exp
@@ -15,5 +15,5 @@ expect "The size of the LICENSE file is: 1915 bytes\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/file.exp b/ci/expect_scripts/file.exp
@@ -0,0 +1,97 @@
+#!/usr/bin/expect
+
+# uncomment line below for debugging
+# exp_internal 1
+
+set timeout 7
+
+source ./ci/expect_scripts/shared-code.exp
+
+spawn $env(TESTS_DIR)file
+
+expect "Testing some File functions..." {
+    expect "This will create and manipulate test files in the current directory." {
+        
+        # Test File.write_bytes! and File.read_bytes!
+        expect "Testing File.write_bytes! and File.read_bytes!:" {
+            expect "Bytes in test_bytes.txt: \\\[72, 101, 108, 108, 111, 44, 32, 87, 111, 114, 108, 100, 33\\\]" {
+                
+                # Test File.write!
+                expect "Testing File.write!:" {
+                    expect "Content of test_write.json: {\"some\":\"json stuff\"}" {
+                        
+                        # Test File.is_file!
+                        expect "Testing File.is_file!:" {
+                            expect "✓ test_bytes.txt is confirmed to be a file" {
+                                
+                                # Test File.is_sym_link!
+                                expect "Testing File.is_sym_link!:" {
+                                    expect "✓ test_bytes.txt is not a symbolic link" {
+                                        expect "✓ test_symlink.txt is a symbolic link" {
+                                            
+                                            # Test File.type!
+                                            expect "Testing File.type!:" {
+                                                expect "test_bytes.txt file type: IsFile" {
+                                                    expect ". file type: IsDir" {
+                                                        expect "test_symlink.txt file type: IsSymLink" {
+                                                            
+                                                            # Test File.open_reader_with_capacity!
+                                                            expect "Testing File.open_reader_with_capacity!:" {
+                                                                expect "✓ Successfully opened reader with 3 byte capacity" {
+                                                                    
+                                                                    # Test reading lines from file
+                                                                    expect "Reading lines from file:" {
+                                                                        expect "Line 1: First line" {
+                                                                            expect "" {
+                                                                                expect "Line 2: Second line" {
+                                                                                    expect "" {
+                                                                                        
+                                                                                        # Test File.hard_link!
+                                                                                        expect "Testing File.hard_link!:" {
+                                                                                            expect "✓ Successfully created hard link: test_link_to_original.txt" {
+                                                                                                expect "Hard link inodes should be equal:" {
+                                                                                                    expect "Bool.true" {
+                                                                                                        expect "✓ Hard link contains same content as original" {
+                                                                                                            
+                                                                                                            # Cleanup phase
+                                                                                                            expect "Cleaning up test files..." {
+                                                                                                                expect "✓ Deleted all files." {
+                                                                                                                    
+                                                                                                                    # Final completion message
+                                                                                                                    expect "✓ All File function tests completed! ✓" {
+                                                                                                                        expect eof {
+                                                                                                                            check_exit_and_segfault
+                                                                                                                        }
+                                                                                                                    }
+                                                                                                                }
+                                                                                                            }
+                                                                                                        }
+                                                                                                    }
+                                                                                                }
+                                                                                            }
+                                                                                        }
+                                                                                    }
+                                                                                }
+                                                                            }
+                                                                        }
+                                                                    }
+                                                                }
+                                                            }
+                                                        }
+                                                    }
+                                                }
+                                            }
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        }
+    }
+}
+
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
+exit 1
diff --git a/ci/expect_scripts/hello-world.exp b/ci/expect_scripts/hello-world.exp
@@ -15,5 +15,5 @@ expect "Hello, World!\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/http.exp b/ci/expect_scripts/http.exp
@@ -31,5 +31,5 @@ expect "I received 'Hello utf8' from the server.\r\n" {
 
 exec kill $server_pid
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/locale.exp b/ci/expect_scripts/locale.exp
@@ -17,5 +17,5 @@ expect -re {The most preferred locale for this system or application: [a-zA-Z\-]
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/path.exp b/ci/expect_scripts/path.exp
@@ -16,5 +16,5 @@ expect "is_file: Bool.true\r\nis_dir: Bool.false\r\nis_sym_link: Bool.false\r\nt
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/print.exp b/ci/expect_scripts/print.exp
@@ -15,5 +15,5 @@ expect "Hello, world!\r\nNo newline after me.Hello, error!\r\nErr with no newlin
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/sqlite-basic.exp b/ci/expect_scripts/sqlite-basic.exp
@@ -24,5 +24,5 @@ expect "All Todos:" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/sqlite-everything.exp b/ci/expect_scripts/sqlite-everything.exp
@@ -35,5 +35,5 @@ expect "All Todos:" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/sqlite.exp b/ci/expect_scripts/sqlite.exp
@@ -28,5 +28,5 @@ expect -exact "Rows: {col_bytes: \[72, 101, 108, 108, 111\], col_f32: 78.9, col_
     }
 #}
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/stdin-basic.exp b/ci/expect_scripts/stdin-basic.exp
@@ -24,5 +24,5 @@ expect "Hi, John Doe! 👋\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/stdin-pipe.exp b/ci/expect_scripts/stdin-pipe.exp
@@ -17,5 +17,5 @@ expect "This is what you piped in: \"hey\"\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/tcp-client.exp b/ci/expect_scripts/tcp-client.exp
@@ -23,5 +23,5 @@ expect "Connected!\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/tcp.exp b/ci/expect_scripts/tcp.exp
@@ -36,5 +36,5 @@ expect "Testing Tcp module functions" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/temp-dir.exp b/ci/expect_scripts/temp-dir.exp
@@ -16,5 +16,5 @@ expect -re "The temp dir path is /\[^\r\n\]+\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/terminal-app-snake.exp b/ci/expect_scripts/terminal-app-snake.exp
@@ -29,5 +29,5 @@ expect "Score: 0\r\n" {
     
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/time.exp b/ci/expect_scripts/time.exp
@@ -15,5 +15,5 @@ expect -re "Completed in \[0-9]+ ns\r\n" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/url.exp b/ci/expect_scripts/url.exp
@@ -85,5 +85,5 @@ expect "Testing Url module functions..." {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/ci/expect_scripts/utc.exp b/ci/expect_scripts/utc.exp
@@ -37,5 +37,5 @@ expect -re "Current time in milliseconds since epoch: \[0-9\]+" {
     }
 }
 
-puts stderr "\nExpect script failed: output was different from expected value."
+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
 exit 1
diff --git a/crates/roc_host/src/lib.rs b/crates/roc_host/src/lib.rs
@@ -324,6 +324,7 @@ pub fn init() {
         roc_fx_file_time_accessed as _,
         roc_fx_file_time_modified as _,
         roc_fx_file_time_created as _,
+        roc_fx_hard_link as _,
         roc_fx_cwd as _,
         roc_fx_posix_time as _,
         roc_fx_sleep_millis as _,
@@ -765,11 +766,11 @@ pub extern "C" fn roc_fx_dir_delete_all(
 }
 
 #[no_mangle]
-pub extern "C" fn roc_fx_hardLink(
-    path_from: &RocList<u8>,
-    path_to: &RocList<u8>,
+pub extern "C" fn roc_fx_hard_link(
+    path_original: &RocList<u8>,
+    path_link: &RocList<u8>,
 ) -> RocResult<(), roc_io_error::IOErr> {
-    roc_file::hard_link(path_from, path_to)
+    roc_file::hard_link(path_original, path_link)
 }
 
 #[no_mangle]
diff --git a/examples/http.roc b/examples/http.roc
@@ -1,6 +1,6 @@
 app [main!] {
     pf: platform "../platform/main.roc",
-    json: "https://github.com/lukewilliamboswell/roc-json/releases/download/0.12.0/1trwx8sltQ-e9Y2rOB4LWUWLS_sFVyETK8Twl0i9qpw.tar.gz",
+    json: "https://github.com/lukewilliamboswell/roc-json/releases/download/0.13.0/RqendgZw5e1RsQa3kFhgtnMP8efWoqGRsAvubx4-zus.tar.br",
 }
 
 import pf.Http
@@ -10,7 +10,13 @@ import pf.Arg exposing [Arg]
 
 # Demo of all basic-cli Http functions
 
-# To run this example: check the README.md in this folder
+# To run this example: 
+# ```
+# nix develop
+# cd basic-cli/ci/rust_http_server
+# cargo run
+# ```
+# Then in another terminal: follow the steps in the README.md file of this folder.
 
 main! : List Arg => Result {} _
 main! = |_args|
diff --git a/platform/File.roc b/platform/File.roc
@@ -170,17 +170,17 @@ read_utf8! = |path_str|
 # read = |path, fmt|
 #    Path.read! (Path.from_str path) fmt
 
-## Creates a new hard link on the filesystem.
+## Creates a new [hard link](https://en.wikipedia.org/wiki/Hard_link) on the filesystem.
 ##
 ## The link path will be a link pointing to the original path.
 ## Note that systems often require these two paths to both be located on the same filesystem.
 ##
 ## This uses [rust's std::fs::hard_link](https://doc.rust-lang.org/std/fs/fn.hard_link.html).
 ##
 ## > [Path.hard_link!] does the same thing, except it takes a [Path] instead of a [Str].
-hard_link! : Str => Result {} [LinkErr IOErr]
-hard_link! = |path_str|
-    Path.hard_link!(Path.from_str(path_str))
+hard_link! : Str, Str => Result {} [LinkErr IOErr]
+hard_link! = |path_str_original, path_str_link|
+    Path.hard_link!(Path.from_str(path_str_original), Path.from_str(path_str_link))
 
 ## Returns True if the path exists on disk and is pointing at a directory.
 ## Returns False if the path exists and it is not a directory. If the path does not exist,
diff --git a/platform/Host.roc b/platform/Host.roc
@@ -91,7 +91,7 @@ dir_create_all! : List U8 => Result {} InternalIOErr.IOErrFromHost
 dir_delete_empty! : List U8 => Result {} InternalIOErr.IOErrFromHost
 dir_delete_all! : List U8 => Result {} InternalIOErr.IOErrFromHost
 
-hard_link! : List U8 => Result {} InternalIOErr.IOErrFromHost
+hard_link! : List U8, List U8 => Result {} InternalIOErr.IOErrFromHost
 path_type! : List U8 => Result InternalPath.InternalPathType InternalIOErr.IOErrFromHost
 cwd! : {} => Result (List U8) {}
 temp_dir! : {} => List U8
diff --git a/platform/Path.roc b/platform/Path.roc
diff --git a/tests/file.roc b/tests/file.roc

Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,5 @@ expect "someinput\r\nsomeinput\r\n" {`
`17`	`17`	`}`
`18`	`18`	`}`
`19`	`19`
`20`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`20`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`21`	`21`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -20,5 +20,5 @@ expect "received argument: foo\r\n" {`
`20`	`20`	`}`
`21`	`21`	`}`
`22`	`22`
`23`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`23`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`24`	`24`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,5 @@ expect -exact "EXEC\r\nFOO=BAR\r\nBAZ=DUCK\r\nFOO=BAR\r\n" {`
`16`	`16`	`}`
`17`	`17`	`}`
`18`	`18`
`19`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`19`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`20`	`20`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ expect "Success!\r\n" {`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`18`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`19`	`19`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,5 @@ expect "Your favorite editor is nano!\r\n" {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`24`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`25`	`25`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -57,5 +57,5 @@ expect "Testing Env module functions..." {`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`
`60`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`60`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`61`	`61`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ expect "NotFound\r\n" {`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`18`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`19`	`19`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,5 @@ expect {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`24`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`25`	`25`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ expect "LICENSE file permissions:\r\n Executable: Bool.false\r\n Readable:`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`18`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`19`	`19`	`exit 1`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,5 @@ expect "Done reading file: {bytes_read: 1915, lines_read: 17}\r\n" {`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
`18`		`-puts stderr "\nExpect script failed: output was different from expected value."`
	`18`	+puts stderr "\nExpect script failed: output was different from expected value. uncomment `exp_internal 1` to debug."
`19`	`19`	`exit 1`