fix: preserve clean home routing under subpaths

Author: rmssantos

404.html

@@ -15,7 +15,10 @@
       var routeIndex = segments.findIndex(function (segment) {
         return segment === 'editor' || segment === 'exam' || segment === 'study' || segment === 'privacy-and-storage' || segment === 'roadmaps';
       });
-      var base = '/' + (routeIndex > 0 ? segments.slice(0, routeIndex).join('/') + '/' : '');
+      var baseSegments = routeIndex > 0
+        ? segments.slice(0, routeIndex)
+        : (routeIndex === -1 ? segments.slice(0, -1) : []);
+      var base = '/' + (baseSegments.length ? baseSegments.join('/') + '/' : '');
       var route = routeIndex >= 0 ? segments[routeIndex] : '';
       var params = new URLSearchParams(window.location.search);
       var target = '';

assets/js/router.js

@@ -44,7 +44,10 @@
 
         // The hosted homepage always resolves at the base path, even before a
         // service worker controls the page. Keep index.html only for file mode.
-        if (!isFileMode() && page === 'home') return withBase('');
+        if (!isFileMode() && page === 'home') {
+            const homeUrl = withBase('');
+            return queryString ? `${homeUrl}?${queryString}` : homeUrl;
+        }
 
         if (!cleanRoutesSupported()) {
             const fileMap = {

tests/browser-smoke.mjs

@@ -320,10 +320,15 @@ try {
   const labsHomeHrefs = await labsPage.locator('a[data-route="home"]').evaluateAll(
     (links) => links.map((link) => link.getAttribute('href'))
   );
+  const siteRootUrl = new URL('/', labsPage.url());
   assert.equal(labsHomeHrefs.length, 2, 'The labs page must expose both Home actions through the router.');
   for (const href of labsHomeHrefs) {
     assert.ok(href, 'A labs Home action must have a destination.');
-    assert.doesNotMatch(href, /index\.html/, 'Hosted labs Home actions must not expose index.html.');
+    assert.equal(
+      new URL(href, labsPage.url()).href,
+      siteRootUrl.href,
+      'Hosted labs Home actions must route to the clean site root.'
+    );
   }
   const importedLabHrefs = await labsPage.locator('.lab-refs a').evaluateAll(
     (links) => links.map((link) => link.href)

tests/test_phase1_2_foundations.py

@@ -225,7 +225,7 @@ def test_localhost_requires_an_active_service_worker_for_clean_routes(self):
 
 vm.runInNewContext(source, sandbox);
 const router = sandbox.window.ExamApp.router;
-const homeWithoutController = router.buildUrl('home');
+const homeWithoutController = router.buildUrl('home', { utm_source: 'labs' });
 sandbox.window.location.pathname = '/examplar/labs.html';
 const labsHomeWithoutController = router.buildUrl('home');
 sandbox.window.location.pathname = '/examplar/index.html';
@@ -239,7 +239,7 @@ def test_localhost_requires_an_active_service_worker_for_clean_routes(self):
 """
         payload = run_node_snippet(script_path, node_script)
 
-        self.assertEqual("/examplar/", payload["homeWithoutController"])
+        self.assertEqual("/examplar/?utm_source=labs", payload["homeWithoutController"])
         self.assertEqual("/examplar/", payload["labsHomeWithoutController"])
         self.assertEqual("roadmaps.html", payload["withoutController"])
         self.assertEqual("/examplar/roadmaps", payload["withController"])

tests/test_server_routes.py

@@ -139,6 +139,7 @@ def test_roadmaps_fallback_preserves_hosted_base_and_query(self):
 
 console.log(JSON.stringify({
   home: resolve('/missing-page', '?utm_source=linkedin&empty='),
+  projectHome: resolve('/examplar/missing-page', '?utm_campaign=refresh'),
   root: resolve('/roadmaps', '?utm_source=linkedin&empty='),
   project: resolve('/examplar/roadmaps', '?utm_campaign=refresh')
 }));
@@ -156,6 +157,10 @@ def test_roadmaps_fallback_preserves_hosted_base_and_query(self):
             "/?utm_source=linkedin&empty=",
             payload["home"],
         )
+        self.assertEqual(
+            "/examplar/?utm_campaign=refresh",
+            payload["projectHome"],
+        )
         self.assertEqual(
             "/roadmaps.html?utm_source=linkedin&empty=",
             payload["root"],