Instrument component isn't serialized when packetevents is loaded

[personalized-advertising]

Describe the bug
On 26.2, goat horns sent to the client are missing the instrument component for specific instruments such as admire, this causes the dreaded itemstack hash mismatch which causes the item to rubberband in the inventory.

Software brand
Folia 26.2

Version
packetevents-spigot-2.13.0 from modrinth

Plugins
Packetevents

How To Reproduce
/give minecraft:goat_horn[instrument="minecraft:admire_goat_horn"]
For some reason it only breaks with admire
Shows on client side as ponder

Packet events loaded:
Serverside nbt: minecraft:goat_horn[instrument="minecraft:admire_goat_horn"]
Clientside nbt: {count:1,id:"minecraft:goat_horn"} (missing instrument)

Packet events unloaded:
Serverside nbt: minecraft:goat_horn[instrument="minecraft:admire_goat_horn"]
Clientside nbt: {components:{"minecraft:instrument":"minecraft:admire_goat_horn"},count:1,id:"minecraft:goat_horn"}

Expected behavior
Horn nbt should not change when passing through packetevents
In fact, no nbt should change simply by being deserialized by packet events, there are probably other instances of this that I have not discovered, some way to validate packetevents isnt mutating nbt would be a good addition

[personalized-advertising]

Im trying to figure out what could have caused this but im confused, one thing i've noticed is between 1.21.11 and 26.2 the base components of goat horn have changed, could that be a cause?

1.21.11:

 "goat_horn": {
    "instrument": "ABptaW5lY3JhZnQ6cG9uZGVyX2dvYXRfaG9ybg==",
    "item_model": "E21pbmVjcmFmdDpnb2F0X2hvcm4=",
    "item_name": "CggACXRyYW5zbGF0ZQAYaXRlbS5taW5lY3JhZnQuZ29hdF9ob3JuAA==",
    "max_stack_size": "AQ==",
    "rarity": "AQ=="
  },

26.2:

"goat_horn": {
    "instrument": "BQ==",
    "item_model": "E21pbmVjcmFmdDpnb2F0X2hvcm4=",
    "item_name": "CggACXRyYW5zbGF0ZQAYaXRlbS5taW5lY3JhZnQuZ29hdF9ob3JuAA==",
    "max_stack_size": "AQ==",
    "rarity": "AQ=="
  },

and under the hood it now uses "delayed component" whatever tf that is:

1.21.11:

 public static final Item GOAT_HORN = registerItem(
        "goat_horn",
        InstrumentItem::new,
        new Item.Properties().rarity(Rarity.UNCOMMON).stacksTo(1)
        .component(DataComponents.INSTRUMENT, new InstrumentComponent(Instruments.PONDER_GOAT_HORN))
    );

26.2:

public static final Item GOAT_HORN = registerItem(
        ItemIds.GOAT_HORN,
        InstrumentItem::new,
        new Item.Properties().rarity(Rarity.UNCOMMON).stacksTo(1)
            .delayedComponent(DataComponents.INSTRUMENT, context -> new InstrumentComponent(context.getOrThrow(Instruments.PONDER_GOAT_HORN)))
    );

[personalized-advertising]

Its not encoding admire because it thinks admire is the default base compoent because "instrument": "BQ==", BQ = 5 which is the registry id 5 which is admire horn

[personalized-advertising]

@booky10 how are the mappings generated? I cannot find the program that generates them, it has a bug in it clearly because goat_horn base component instrument is not admire

[booky10]

See https://github.com/packetevents/data-generators