PE doesn't handle LEGACY_SERVER_LIST_PING

[rafi67000]

Describe the bug

PacketEvents doesn't call Protocol events for LEGACY_SERVER_LIST_PING.

Minecraft servers handle LEGACY_SERVER_LIST_PING in "legacy_query" handler and calls ByteBuf#release

"legacy_handler" is before decoder
PacketEvents injects before "decoder"

the order is:
legacy_query > PE-decoder > decoder
therefore PE never receives it in the first place

Software brand
paper/spigot

How To Reproduce
Listen to LEGACY_SERVER_LIST_PING packet

Expected behavior
PE calls handshake event of packetType LEGACY_SERVER_LIST_PING

Screenshots

server pipeline:

place of ByteBuf#release by "legacy_query":

relevant PE injection point:

[rafi67000]

fuck you bot https://www.virustotal.com/gui/file-analysis/OGJjZDY0YzljYmE0YmUyODFiNTM5NDliZDMyYzdkOGE6MTc4MzQ1ODI1NA==

[rafi67000]

seems like it will also happen on velocity

[booky10]

I am not sure if we want to support this in packetevents, as this is a lot of platform-dependant injection-logic which has a really niche usecase

[XIII-MC]

Well i agree it is niche but why keep the packet type in PE then ? It's a bit confusing seeing the packet exist (both server and client side btw) but not being able to use it (PE doesnt even see the packet via PacketReceive or PacketSend event).

[booky10]

@retrooper do you know why it exists?