Skip to content

Commit f0f28c8

Browse files
committed
Add test for using fixnum for every
Check for empty should be done on string
1 parent f7623e3 commit f0f28c8

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

lib/resque/scheduler.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def load_schedule_job(name, config)
136136
interval_defined = false
137137
interval_types = %w(cron every)
138138
interval_types.each do |interval_type|
139-
next unless !config[interval_type].nil? && !config[interval_type].empty?
139+
next unless !config[interval_type].nil? && !config[interval_type].to_s.empty?
140140
args = optionizate_interval_value(config[interval_type])
141141
args = [args, nil, job: true] if args.is_a?(::String)
142142

test/scheduler_test.rb

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,20 @@
132132
assert job.opts.keys.include?(:first_in)
133133
end
134134

135+
test 'load_schedule_job with every fixnum' do
136+
Resque::Scheduler.load_schedule_job(
137+
'some_ivar_job',
138+
'every' => 30,
139+
'class' => 'SomeIvarJob',
140+
'args' => '/tmp'
141+
)
142+
143+
assert_equal(1, Resque::Scheduler.rufus_scheduler.jobs.size)
144+
assert_equal(1, Resque::Scheduler.scheduled_jobs.size)
145+
assert Resque::Scheduler.scheduled_jobs.keys.include?('some_ivar_job')
146+
job = Resque::Scheduler.scheduled_jobs['some_ivar_job']
147+
end
148+
135149
test 'load_schedule_job with cron with options' do
136150
Resque::Scheduler.load_schedule_job(
137151
'some_ivar_job',

0 commit comments

Comments
 (0)