Skip to content

fix show success decorator for FailedOver on DR topology#2800

Open
TimothyAsirJeyasing wants to merge 1 commit into
red-hat-storage:masterfrom
TimothyAsirJeyasing:bz-6797-fix-success-icon-color-in-dr-topologyview
Open

fix show success decorator for FailedOver on DR topology#2800
TimothyAsirJeyasing wants to merge 1 commit into
red-hat-storage:masterfrom
TimothyAsirJeyasing:bz-6797-fix-success-icon-color-in-dr-topologyview

Conversation

@TimothyAsirJeyasing
Copy link
Copy Markdown
Contributor

@TimothyAsirJeyasing TimothyAsirJeyasing commented May 12, 2026

https://redhat.atlassian.net/browse/DFBUGS-6797

getDecoratorForStatus mapped DRStatus.FailedOver to the warning triangle while sidebar-utils and disaster-recovery already treat FailedOver as a successful completed failover. Topology app nodes use getDecoratorForStatus for quadrant decorators, which caused the BZ mismatch on the target cluster.

Align FailedOver with Relocated/Healthy: CheckCircle and NodeStatus.success.

getDecoratorForStatus mapped DRStatus.FailedOver to the warning triangle
while sidebar-utils and disaster-recovery already treat FailedOver as a
successful completed failover. Topology app nodes use getDecoratorForStatus
for quadrant decorators, which caused the BZ mismatch on the target cluster.

Align FailedOver with Relocated/Healthy: CheckCircle and NodeStatus.success.

Signed-off-by: Timothy Asir Jeyasingh <tim.gluster@gmail.com>
@TimothyAsirJeyasing
Copy link
Copy Markdown
Contributor Author

before:
image

after:
image

@SanjalKatiyar
Copy link
Copy Markdown
Collaborator

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Copy Markdown
Collaborator

/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants