Include NFS to resource profile calculations#2776
Conversation
|
/test odf-console-e2e-aws |
Soundarya189r
force-pushed
the
DFBUGS-5411
branch
from
24587f5 to
cfd6a00
Compare
|
/retest-required |
SanjalKatiyar
left a comment
SanjalKatiyar
left a comment
There was a problem hiding this comment.
We are missing few changes, plz check #2556 for reference.
getResourceProfileRequirements ar multiple places as well, so we should be adding args accordingly at all places: https://github.com/search?q=repo%3Ared-hat-storage%2Fodf-console%20getResourceProfileRequirements&type=code
Soundarya189r
force-pushed
the
DFBUGS-5411
branch
2 times, most recently
from
93f2f21 to
dfd2cbb
Compare
|
/approve |
|
/lgtm cancel |
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Soundarya189r The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold cancel |
| const ProfileRequirementsModalText: React.FC< | ||
| ProfileRequirementsModalTextProps | ||
| > = ({ selectedProfile, osdAmount, architecture }) => { | ||
| > = ({ selectedProfile, osdAmount, architecture, enableNFS }) => { |
There was a problem hiding this comment.
from where value of enableNFS flag comes from for this modal ??
| <ConfigurePerformance | ||
| onResourceProfileChange={onProfileChange} | ||
| resourceProfile={resourceProfile} | ||
| profileRequirementsText={ProfileRequirementsModalText} |
There was a problem hiding this comment.
when more than 3 nodes selected Day 2 
|
Soundarya189r
force-pushed
the
DFBUGS-5411
branch
from
dfd2cbb to
8d08057
Compare
Soundarya189r
force-pushed
the
DFBUGS-5411
branch
from
8d08057 to
ea2655e
Compare
| ) | ||
| .reduce((accumulator: number, current: number) => accumulator + current); | ||
| const architecture = getNodeArchitectureFromState(selectedNodes); | ||
| const enableNFS = storageCluster?.spec?.nfs?.enable || false; |
There was a problem hiding this comment.
@SanjalKatiyar please check now, I am checking for the spec.nfs.enable in the storageCluster CR
2 participants
https://redhat.atlassian.net/browse/DFBUGS-5411
After NFS selection"
