Skip to content

Relax package path assumptions in download_version_url #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinstuder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Relax package path assumptions in download_version_url #441

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
841fa2d
Relax package path assumptions in download_version_url; closes r-lib/…
martinstuder Sep 23, 2019
d856b4c
Replace use of endsWith with substr for backwards compatibility
martinstuder Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions R/install-version.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,12 @@ download_version_url <- function(package, version, repos, type) {
# Grab the latest one: only happens if pulled from CRAN
package.path <- row.names(info)[nrow(info)]
} else {
package.path <- paste(package, "/", package, "_", version, ".tar.gz",
package.filename <- paste(package, "_", version, ".tar.gz",
sep = "")
if (!(package.path %in% row.names(info))) {
idx <- endsWith(row.names(info), package.filename)
Copy link
Copy Markdown
Member

@jimhester jimhester Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about matching with basename() instead?

if(any(idx)) {
package.path <- row.names(info)[idx][1L]
} else {
stop(sprintf("version '%s' is invalid for package '%s'", version,
package))
}
Expand Down