Refactor hci_core_{source,sink}_v2 as thin wrappers

This commit refactors hci_core_{source,sink}_v2, which introduced
ready/valid job queues, as thin wrappers around "traditional"
hci_core_{source,sink}.
Most (if not all) downstream HWPEs use non-v2 streamers, which
still receive significant updates and improvements. On the other
hand, v2 streamers have been left untouched and are only lightly
tested.

Moving the v2 streamers to thin wrappers has the primary advantage
that any code duplication (and divergence) is removed.
Eventually, non-v2 streamers may be deprecated and in that case
their functionality may be reintegrated in the v2 streamers, but
this can happen only if most downstream HWPEs migrate to v2.

Author: FrancescoConti

Bender.yml

@@ -46,7 +46,6 @@ sources:
       - rtl/core/hci_core_r_id_filter.sv
       - rtl/core/hci_core_rob.sv
       - rtl/core/hci_core_source.sv
-      - rtl/core/hci_core_source_v2.sv
       - rtl/core/hci_core_split.sv
       - rtl/ecc/hci_ecc_dec.sv
       - rtl/ecc/hci_ecc_enc.sv
@@ -63,10 +62,11 @@ sources:
       - rtl/parity/hci_copy_sink.sv
       # Level 3
       - rtl/core/hci_core_sink.sv
+      - rtl/core/hci_core_source_v2.sv
       - rtl/ecc/hci_ecc_source.sv
-      - rtl/core/hci_core_sink_v2.sv
       - rtl/interco/hci_router.sv
       # Level 4
+      - rtl/core/hci_core_sink_v2.sv
       - rtl/ecc/hci_ecc_interconnect.sv
       - rtl/ecc/hci_ecc_sink.sv
       - rtl/hci_interconnect.sv

rtl/common/hci_package.sv

@@ -67,15 +67,18 @@ package hci_package;
     hwpe_stream_package::flags_addressgen_v4_t addressgen_flags;
   } hci_streamer_flags_t;
 
+  // Same as hci_streamer_ctrl_t / hci_streamer_flags_t, except that the v2 streamers accept jobs
+  // through a valid/ready handshake instead of the req_start/ready_start pair.
   typedef struct packed {
     logic                                     valid;
-    hwpe_stream_package::ctrl_addressgen_v3_t addressgen_ctrl;
+    hwpe_stream_package::ctrl_addressgen_v4_t addressgen_ctrl;
   } hci_streamer_v2_ctrl_t;
 
   typedef struct packed {
     logic                                      ready;
     logic                                      done;
-    hwpe_stream_package::flags_addressgen_v3_t addressgen_flags;
+    logic                                      no_valid_transfers;
+    hwpe_stream_package::flags_addressgen_v4_t addressgen_flags;
   } hci_streamer_v2_flags_t;
 
   typedef enum {