fix: Fail the build when a Pester run fails for any reason (#133)

Test-PSBuildPester gated pass/fail only on FailedCount, so a
BeforeAll/AfterAll that threw or a test file that errored during
discovery left the count at zero and the build passed despite tests
never running. Gate on the run's aggregate Result property instead,
which Pester derives from all failure categories.

Also switch this repo's own psakeFile.ps1 Pester gate (the
three-counter sum from #128) to the same Result check so both gates
share one definition of "failed".

Companion to #128. Same bug lineage as #31, #52, and #57.

Author: tablackburn

CHANGELOG.md

@@ -7,6 +7,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+### Fixed
+
+- [**#133**](https://github.com/psake/PowerShellBuild/pull/133)
+  `Test-PSBuildPester` now fails the build when a Pester run fails for any
+  reason, not only when individual tests fail. Previously the function gated
+  only on `FailedCount`, so a `BeforeAll`/`AfterAll` that threw or a test file
+  that errored during discovery left the count at zero and the build passed
+  despite tests never running. The gate now checks the run's aggregate
+  `Result` property, which Pester derives from all failure categories.
+  Companion to [#128](https://github.com/psake/PowerShellBuild/pull/128),
+  which fixes the same gap in this repository's own build file.
+
 ## [0.8.1] 2026-06-03
 
 ### Fixed

PowerShellBuild/Public/Test-PSBuildPester.ps1

@@ -104,7 +104,10 @@ function Test-PSBuildPester {
 
         $testResult = Invoke-Pester -Configuration $configuration -Verbose:$VerbosePreference
 
-        if ($testResult.FailedCount -gt 0) {
+        # Gate on the run's aggregate result rather than FailedCount alone. A failed
+        # BeforeAll/AfterAll or a container that errors during discovery leaves
+        # FailedCount at 0, but Pester still marks the overall Result as 'Failed'.
+        if ($testResult.Result -eq 'Failed') {
             throw $LocalizedData.PesterTestsFailed
         }
 

psakeFile.ps1

@@ -51,7 +51,9 @@ task Pester -depends Build {
 
     $testResults = Invoke-Pester -Configuration $pesterConfiguration
 
-    if (($testResults.FailedCount + $testResults.FailedBlocksCount + $testResults.FailedContainersCount) -gt 0) {
+    # Result aggregates every failure category (failed tests, blocks, containers),
+    # matching the gate in Test-PSBuildPester.
+    if ($testResults.Result -eq 'Failed') {
         $testResults | Format-List
         Write-Error -Message 'One or more Pester tests failed. Build cannot continue!'
     }