Server: Socket::GetSocket(s)ByIP(): Remove unused sockaddr_in variable

provigz · provigz · commit a5bd296e9806 · 2025-11-10T21:57:17.000+02:00
A leftover from when I was using `getpeername()` to get the address of a socket each time it was needed.
diff --git a/InternetGamesServer/Socket.cpp b/InternetGamesServer/Socket.cpp
@@ -228,9 +228,6 @@ Socket::GetAddressString(IN_ADDR address)
 std::vector<Socket*>
 Socket::GetSocketsByIP(const std::string& ip)
 {
-	sockaddr_in socketInfo;
-	int socketInfoSize = sizeof(socketInfo);
-
 	std::vector<Socket*> sockets;
 	for (Socket* socket : s_socketList)
 	{
@@ -243,9 +240,6 @@ Socket::GetSocketsByIP(const std::string& ip)
 Socket*
 Socket::GetSocketByIP(const std::string& ip, USHORT port)
 {
-	sockaddr_in socketInfo;
-	int socketInfoSize = sizeof(socketInfo);
-
 	for (Socket* socket : s_socketList)
 	{
 		if (socket->m_address.ip == ip && socket->m_address.port == port)

Original file line number	Diff line number	Diff line change
`@@ -228,9 +228,6 @@ Socket::GetAddressString(IN_ADDR address)`
`228`	`228`	`std::vector<Socket*>`
`229`	`229`	`Socket::GetSocketsByIP(const std::string& ip)`
`230`	`230`	`{`
`231`		`- sockaddr_in socketInfo;`
`232`		`- int socketInfoSize = sizeof(socketInfo);`
`233`		`-`
`234`	`231`	`std::vector<Socket*> sockets;`
`235`	`232`	`for (Socket* socket : s_socketList)`
`236`	`233`	`{`
`@@ -243,9 +240,6 @@ Socket::GetSocketsByIP(const std::string& ip)`
`243`	`240`	`Socket*`
`244`	`241`	`Socket::GetSocketByIP(const std::string& ip, USHORT port)`
`245`	`242`	`{`
`246`		`- sockaddr_in socketInfo;`
`247`		`- int socketInfoSize = sizeof(socketInfo);`
`248`		`-`
`249`	`243`	`for (Socket* socket : s_socketList)`
`250`	`244`	`{`
`251`	`245`	`if (socket->m_address.ip == ip && socket->m_address.port == port)`