feat(loadflow-validation): add private extensions validation

samirromdhani · samirromdhani · commit 75f191e0ebbd · 2026-04-16T17:52:24.000+02:00
Signed-off-by: Samir Romdhani &lt;samir.romdhani_externe@rte-france.com&gt;

add ExtensionsValidation tests

Signed-off-by: Samir Romdhani &lt;samir.romdhani_externe@rte-france.com&gt;

WIP

Signed-off-by: Samir Romdhani &lt;samir.romdhani_externe@rte-france.com&gt;
diff --git a/loadflow/loadflow-validation/note.md b/loadflow/loadflow-validation/note.md
@@ -0,0 +1,23 @@
+https://powsybl.readthedocs.io/projects/powsybl-core/en/stable/user/itools/loadflow-validation.html
+
+## Flows (BranchData) can be constructed from
+    - Line Flows
+    - TwoWindingsTransformer Flows
+         - Used Extensions
+            - TwoWindingsTransformerPhaseAngleClock
+                - phaseAngleClock
+    - TieLine Flows
+
+## ThreeWindingsTransformer
+    - Used Extensions
+        - ThreeWindingsTransformerPhaseAngleClock
+            - phaseAngleClock2
+            - phaseAngleClock3
+
+```sh
+./distribution-core/target/powsybl/bin/itools loadflow-validation \
+  --case-file ./distribution-core/test/network.xiidm \
+  --output-folder /tmp/lv-out \
+  --load-flow \
+  --verbose
+```
diff --git a/loadflow/loadflow-validation/pom.xml b/loadflow/loadflow-validation/pom.xml
@@ -99,7 +99,10 @@
             <groupId>org.slf4j</groupId>
             <artifactId>slf4j-simple</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.powsybl</groupId>
+            <artifactId>powsybl-tools-test</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
-
 </project>
-
diff --git a/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationTool.java b/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/ValidationTool.java
@@ -17,6 +17,7 @@
 import com.powsybl.iidm.network.tools.ConversionToolUtils;
 import com.powsybl.loadflow.LoadFlow;
 import com.powsybl.loadflow.LoadFlowParameters;
+import com.powsybl.loadflow.validation.extension.ExtensionsValidation;
 import com.powsybl.loadflow.validation.io.ValidationWriters;
 import com.powsybl.tools.Command;
 import com.powsybl.tools.Tool;
@@ -53,6 +54,7 @@ public class ValidationTool implements Tool {
     private static final String COMPARE_RESULTS = "compare-results";
     private static final String RUN_COMPUTATION = "run-computation";
     private static final String COMPARE_CASE_FILE = "compare-case-file";
+    public static final String WITH_EXTENSIONS_OPTION = "with-extensions";
 
     private static final Command COMMAND = new Command() {
 
@@ -120,6 +122,11 @@ public Options getOptions() {
                     .build());
             options.addOption(createImportParametersFileOption());
             options.addOption(createImportParameterOption());
+            options.addOption(Option.builder().longOpt(WITH_EXTENSIONS_OPTION)
+                    .desc("enable extension validation")
+                    .hasArg(false)
+                    .argName("EXTENSIONS")
+                    .build());
             return options;
         }
 
@@ -149,6 +156,7 @@ public void run(CommandLine line, ToolRunningContext context) throws Exception {
         if (line.hasOption(OUTPUT_FORMAT)) {
             config.setValidationOutputWriter(ValidationOutputWriter.valueOf(line.getOptionValue(OUTPUT_FORMAT)));
         }
+
         ComparisonType comparisonType = null;
         if (line.hasOption(COMPARE_RESULTS)) {
             config.setCompareResults(true);
@@ -161,6 +169,10 @@ public void run(CommandLine line, ToolRunningContext context) throws Exception {
                                     .collect(Collectors.toSet());
         }
         Network network = loadNetwork(caseFile, line, context);
+        if (line.hasOption(WITH_EXTENSIONS_OPTION)) {
+            ExtensionsValidation extensionsValidation = new ExtensionsValidation();
+            extensionsValidation.runExtensionValidations(network, config, outputFolder, context);
+        }
         try (ValidationWriters validationWriters = new ValidationWriters(network.getId(), validationTypes, outputFolder, config)) {
             if (config.isCompareResults() && ComparisonType.COMPUTATION.equals(comparisonType)) {
                 Preconditions.checkArgument(line.hasOption(LOAD_FLOW) || line.hasOption(RUN_COMPUTATION),
diff --git a/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/extension/ExtensionValidation.java b/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/extension/ExtensionValidation.java
@@ -0,0 +1,31 @@
+/**
+ * Copyright (c) 2026, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+package com.powsybl.loadflow.validation.extension; import com.powsybl.iidm.network.Network;
+import com.powsybl.loadflow.validation.ValidationConfig;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Objects;
+
+/**
+ *
+ * @author Samir Romdhani {@literal <samir.romdhani at rte-france.com>}
+ */
+public interface ExtensionValidation {
+
+    String getType();
+
+    String getName();
+
+    boolean check(Network network, ValidationConfig config, Path outputFile) throws IOException;
+
+    default Path getOutputFile(Path folder) {
+        Objects.requireNonNull(folder);
+        return folder.resolve(getName() + ".csv");
+    }
+}
diff --git a/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/extension/ExtensionsValidation.java b/loadflow/loadflow-validation/src/main/java/com/powsybl/loadflow/validation/extension/ExtensionsValidation.java
@@ -0,0 +1,57 @@
+/**
+ * Copyright (c) 2026, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+package com.powsybl.loadflow.validation.extension;
+
+import com.google.common.base.Supplier;
+import com.google.common.base.Suppliers;
+import com.google.common.collect.Lists;
+import com.powsybl.iidm.network.Network;
+import com.powsybl.loadflow.validation.ValidationConfig;
+import com.powsybl.tools.ToolRunningContext;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.List;
+import java.util.Optional;
+import java.util.ServiceLoader;
+
+/**
+ * @author Samir Romdhani {@literal <samir.romdhani at rte-france.com>}
+ */
+public class ExtensionsValidation {
+
+    private static final Supplier<List<ExtensionValidation>> EXTENSIONS = Suppliers.memoize(() -> Lists.newArrayList(
+            ServiceLoader.load(ExtensionValidation.class, ExtensionsValidation.class.getClassLoader())));
+
+    public static List<ExtensionValidation> getExtensions() {
+        return EXTENSIONS.get();
+    }
+
+    public static List<String> getExtensionsNames() {
+        return getExtensions().stream().map(ExtensionValidation::getName).toList();
+    }
+
+    public static Optional<ExtensionValidation> getExtension(String name) {
+        return getExtensions().stream().filter(v -> v.getName().equals(name)).findFirst();
+    }
+
+    public void runExtensionValidations(Network network, ValidationConfig config, Path outputFolder, ToolRunningContext context) {
+
+        getExtensions().forEach(extensionValidation -> {
+            try {
+                boolean success = extensionValidation.check(network, config, extensionValidation.getOutputFile(outputFolder));
+                String message = "Validate extension behaviour of network " + network.getId()
+                        + " - extension validation type: " + extensionValidation.getType()
+                        + " - result: " + (success ? "success" : "fail");
+                context.getOutputStream().println(message);
+            } catch (IOException e) {
+                throw new java.io.UncheckedIOException(e);
+            }
+        });
+    }
+}
diff --git a/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/ValidationConfigTest.java b/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/ValidationConfigTest.java
@@ -99,7 +99,7 @@ void checkCompleteConfig() throws Exception {
     }
 
     @Test
-    void checkSetters() throws Exception {
+    void checkSetters() {
         ValidationConfig config = ValidationConfig.load(platformConfig);
         config.setThreshold(threshold);
         config.setVerbose(verbose);
diff --git a/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/ValidationToolTest.java b/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/ValidationToolTest.java
@@ -0,0 +1,68 @@
+/**
+ * Copyright (c) 2026, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+package com.powsybl.loadflow.validation;
+
+import com.powsybl.tools.Tool;
+import com.powsybl.tools.test.AbstractToolTest;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.util.Collections;
+import java.util.Objects;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+/**
+ *
+ * @author Samir Romdhani {@literal <samir.romdhani at rte-france.com>}
+ */
+class ValidationToolTest extends AbstractToolTest {
+
+    private static final String COMMAND_NAME = "loadflow-validation";
+    private final ValidationTool tool = new ValidationTool();
+
+    @BeforeEach
+    public void setUp() throws Exception {
+        super.setUp();
+        Files.copy(Objects.requireNonNull(getClass().getResourceAsStream("/network.xiidm")), fileSystem.getPath("network.xiidm"));
+    }
+
+    @Override
+    protected Iterable<Tool> getTools() {
+        return Collections.singleton(tool);
+    }
+
+    @Override
+    public void assertCommand() {
+        assertEquals(COMMAND_NAME, tool.getCommand().getName());
+        assertEquals("Computation", tool.getCommand().getTheme());
+        assertEquals("Validate load-flow results of a network", tool.getCommand().getDescription());
+
+        assertCommand(tool.getCommand(), COMMAND_NAME, 12, 2);
+        assertOption(tool.getCommand().getOptions(), "case-file", true, true);
+        assertOption(tool.getCommand().getOptions(), "output-folder", true, true);
+        assertOption(tool.getCommand().getOptions(), "load-flow", false, false);
+        assertOption(tool.getCommand().getOptions(), "types", false, true);
+        assertOption(tool.getCommand().getOptions(), "with-extensions", false, false);
+    }
+
+    @Test
+    void testCommand() {
+        assertCommand();
+    }
+
+    @Test
+    @Disabled
+    void test() throws IOException {
+        //TODO  File network.xiidm does not exist !!!!!
+        assertCommandErrorMatch(new String[]{"loadflow-validation", "--case-file", "network.xiidm", "--output-folder", "result"}, "");
+    }
+}
diff --git a/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/extension/ExtensionValidationMock.java b/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/extension/ExtensionValidationMock.java
@@ -0,0 +1,36 @@
+/**
+ * Copyright (c) 2026, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+package com.powsybl.loadflow.validation.extension; import com.google.auto.service.AutoService;
+import com.powsybl.iidm.network.Network;
+import com.powsybl.loadflow.validation.ValidationConfig;
+
+import java.io.IOException;
+import java.nio.file.Path;
+
+/**
+ *
+ * @author Samir Romdhani {@literal <samir.romdhani at rte-france.com>}
+ */
+@AutoService(ExtensionValidation.class)
+public class ExtensionValidationMock implements ExtensionValidation {
+
+    @Override
+    public String getType() {
+        return "private1";
+    }
+
+    @Override
+    public String getName() {
+        return "extensionValidationMock1";
+    }
+
+    @Override
+    public boolean check(Network network, ValidationConfig config, Path outputFile) throws IOException {
+        return true;
+    }
+}
diff --git a/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/extension/ExtensionsValidationTest.java b/loadflow/loadflow-validation/src/test/java/com/powsybl/loadflow/validation/extension/ExtensionsValidationTest.java
@@ -0,0 +1,92 @@
+/**
+ * Copyright (c) 2026, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ * SPDX-License-Identifier: MPL-2.0
+ */
+package com.powsybl.loadflow.validation.extension;
+
+import com.powsybl.computation.ComputationManager;
+import com.powsybl.iidm.network.Network;
+import com.powsybl.iidm.network.test.EurostagTutorialExample1Factory;
+import com.powsybl.loadflow.validation.ValidationConfig;
+import com.powsybl.tools.ToolRunningContext;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.MockedStatic;
+
+import java.io.IOException;
+import java.io.PrintStream;
+import java.nio.file.FileSystem;
+import java.nio.file.Path;
+import java.util.List;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.*;
+
+/**
+ *
+ * @author Samir Romdhani {@literal <samir.romdhani at rte-france.com>}
+ */
+class ExtensionsValidationTest {
+
+    ExtensionsValidation extensionsValidation = new ExtensionsValidation();
+    private final Network network = EurostagTutorialExample1Factory.create();
+    private final Path outputFolder = mock(Path.class);
+
+    @Test
+    void getExtensionsShouldSucceed() {
+        assertEquals(1, ExtensionsValidation.getExtensions().size());
+    }
+
+    @Test
+    void getExtensionsNamesShouldSucceed() {
+        assertEquals(List.of("extensionValidationMock1"), ExtensionsValidation.getExtensionsNames());
+    }
+
+    @Test
+    void getExtensionShouldReturnExistingExtension() {
+        assertTrue(ExtensionsValidation.getExtension("extensionValidationMock1").isPresent());
+        assertEquals("extensionValidationMock1", ExtensionsValidation.getExtension("extensionValidationMock1").get().getName());
+        assertEquals("private1", ExtensionsValidation.getExtension("extensionValidationMock1").get().getType());
+        when(outputFolder.resolve(anyString())).thenReturn(outputFolder);
+        assertNotNull(ExtensionsValidation.getExtension("extensionValidationMock1").get().getOutputFile(outputFolder));
+    }
+
+    @Test
+    void testRunExtensionValidationsShouldSucceed() throws IOException {
+        //Given
+        ValidationConfig config = ValidationConfig.load();
+        ToolRunningContext context = new ToolRunningContext(mock(PrintStream.class), mock(PrintStream.class), mock(FileSystem.class), mock(ComputationManager.class), mock(ComputationManager.class));
+
+        ExtensionValidation extension1 = mock(ExtensionValidation.class);
+        ExtensionValidation extension2 = mock(ExtensionValidation.class);
+
+        when(extension1.getType()).thenReturn("type1");
+        when(extension1.getOutputFile(outputFolder)).thenReturn(mock(Path.class));
+        when(extension1.check(any(), any(), any())).thenReturn(true);
+
+        when(extension2.getType()).thenReturn("type2");
+        when(extension2.getOutputFile(outputFolder)).thenReturn(mock(Path.class));
+        when(extension2.check(any(), any(), any())).thenReturn(false);
+
+        try (MockedStatic<ExtensionsValidation> mocked = mockStatic(ExtensionsValidation.class)) {
+            mocked.when(ExtensionsValidation::getExtensions).thenReturn(List.of(extension1, extension2));
+            // When
+            extensionsValidation.runExtensionValidations(network, config, outputFolder, context);
+            // Then
+
+            ArgumentCaptor<String> captor = ArgumentCaptor.forClass(String.class);
+            verify(context.getOutputStream(), times(2)).println(captor.capture());
+            List<String> messages = captor.getAllValues();
+            assertTrue(messages.get(0).contains("success"));
+            assertTrue(messages.get(1).contains("fail"));
+
+            // check() was called on extensions
+            verify(extension1, times(1)).check(eq(network), eq(config), any());
+            verify(extension2, times(1)).check(eq(network), eq(config), any());
+        }
+    }
+}
diff --git a/loadflow/loadflow-validation/src/test/resources/config.yml b/loadflow/loadflow-validation/src/test/resources/config.yml
@@ -0,0 +1,13 @@
+loadflow-validation:
+  threshold: 0.1
+  verbose: false
+  load-flow-name: Mock
+  table-formatter-factory: com.powsybl.commons.io.table.CsvTableFormatterFactory
+  epsilon-x: 0.1
+  apply-reactance-correction: false
+  output-writer: CSV_MULTILINE
+  ok-missing-values: false
+  no-requirement-if-reactive-bound-inversion: false
+  compare-results: false
+  check-main-component-only: true
+  no-requirement-if-setpoint-outside-power-bounds: false
diff --git a/loadflow/loadflow-validation/src/test/resources/network.xiidm b/loadflow/loadflow-validation/src/test/resources/network.xiidm

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ void checkCompleteConfig() throws Exception {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`@Test`
`102`		`- void checkSetters() throws Exception {`
	`102`	`+ void checkSetters() {`
`103`	`103`	`ValidationConfig config = ValidationConfig.load(platformConfig);`
`104`	`104`	`config.setThreshold(threshold);`
`105`	`105`	`config.setVerbose(verbose);`