Skip to content

ci: add multi-arch Docker image test workflow#448

Open
Komzpa wants to merge 1 commit into
postgis:masterfrom
Komzpa:codex/multiarch-test-workflow
Open

ci: add multi-arch Docker image test workflow#448
Komzpa wants to merge 1 commit into
postgis:masterfrom
Komzpa:codex/multiarch-test-workflow

Conversation

@Komzpa
Copy link
Copy Markdown
Member

@Komzpa Komzpa commented May 4, 2026

Summary

This is a rescue/follow-up for the stalled multi-arch workflow from #432, based on the direction from review feedback and the ImreSamu/docker-postgis-test prototype.

Changes:

  • adds .github/workflows/test.yml while leaving the existing .github/workflows/main.yml untouched
  • builds and tests release Docker images on ubuntu-24.04 and ubuntu-24.04-arm
  • runs the docker-library/official-images tests before any publish-capable step
  • keeps PR runs test-only; Docker Hub push/manifest/description updates are gated to canonical master non-PR runs
  • publishes to postgis/docker-postgis-test when the gated path is enabled
  • adds generated matrix.yml and teaches update.sh to regenerate it
  • skips placeholder/development targets (17-3.6 Debian placeholder and *-master) from the required generated matrix
  • uses run-id-scoped digest artifact names plus manifest concurrency to avoid cross-run collisions

Local validation

  • bash -n update.sh ci/matrix.sh ci/test-image.sh ci/push-manifest.sh ci/prepare-dockerhub-readme.sh
  • RUNNER_PLATFORMS_JSON='["ubuntu-24.04","ubuntu-24.04-arm"]' bash ci/matrix.sh
  • Ruby YAML parse for .github/workflows/test.yml and matrix.yml
  • git diff --check
  • Local smoke build and official-images test for 17-3.5:
    • docker build -t postgis/postgis:ci-local-17-3.5-default 17-3.5
    • bash ci/test-image.sh postgis/postgis:ci-local-17-3.5-default
    • observed postgres-basics, postgres-initdb, and postgis-basics passing

actionlint was not available locally.

@Komzpa Komzpa force-pushed the codex/multiarch-test-workflow branch from 33b3745 to 07a7f2d Compare May 4, 2026 04:26
@Komzpa Komzpa force-pushed the codex/multiarch-test-workflow branch from 07a7f2d to f0b1ef2 Compare May 13, 2026 22:06
@Komzpa Komzpa marked this pull request as ready for review May 17, 2026 15:54
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0b1ef2c40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if: ${{ steps.push.outcome == 'success' }}
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
name: digests-${{ github.run_id }}-${{ env.VERSION }}-${{ env.VARIANT }}-${{ matrix.runner-platform }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include run attempt in digest artifact name

Use a run-attempt-specific artifact name here, because actions/upload-artifact fails when an artifact with the same name already exists in the same workflow run. This workflow keys the name only by github.run_id, so re-running failed jobs (or re-running the full workflow) for the same run can hit a 409 conflict on this upload step and block manifest merge/publish even when the rebuilt image is valid.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant