ci: add multi-arch Docker image test workflow#448
Conversation
33b3745 to
07a7f2d
Compare
07a7f2d to
f0b1ef2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0b1ef2c40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: ${{ steps.push.outcome == 'success' }} | ||
| uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0 | ||
| with: | ||
| name: digests-${{ github.run_id }}-${{ env.VERSION }}-${{ env.VARIANT }}-${{ matrix.runner-platform }} |
There was a problem hiding this comment.
Include run attempt in digest artifact name
Use a run-attempt-specific artifact name here, because actions/upload-artifact fails when an artifact with the same name already exists in the same workflow run. This workflow keys the name only by github.run_id, so re-running failed jobs (or re-running the full workflow) for the same run can hit a 409 conflict on this upload step and block manifest merge/publish even when the rebuilt image is valid.
Useful? React with 👍 / 👎.
Summary
This is a rescue/follow-up for the stalled multi-arch workflow from #432, based on the direction from review feedback and the ImreSamu/docker-postgis-test prototype.
Changes:
.github/workflows/test.ymlwhile leaving the existing.github/workflows/main.ymluntouchedubuntu-24.04andubuntu-24.04-armmasternon-PR runspostgis/docker-postgis-testwhen the gated path is enabledmatrix.ymland teachesupdate.shto regenerate it17-3.6Debian placeholder and*-master) from the required generated matrixLocal validation
bash -n update.sh ci/matrix.sh ci/test-image.sh ci/push-manifest.sh ci/prepare-dockerhub-readme.shRUNNER_PLATFORMS_JSON='["ubuntu-24.04","ubuntu-24.04-arm"]' bash ci/matrix.sh.github/workflows/test.ymlandmatrix.ymlgit diff --check17-3.5:docker build -t postgis/postgis:ci-local-17-3.5-default 17-3.5bash ci/test-image.sh postgis/postgis:ci-local-17-3.5-defaultpostgres-basics,postgres-initdb, andpostgis-basicspassingactionlintwas not available locally.