Improve cypher error messages

Author: vogti

core/src/main/java/org/polypheny/db/algebra/enumerable/RexToLixTranslator.java

@@ -522,7 +522,7 @@ private Expression translateCall( RexCall call, RexImpTable.NullAs nullAs ) {
         final Operator operator = call.getOperator();
         CallImplementor implementor = RexImpTable.INSTANCE.get( operator );
         if ( implementor == null ) {
-            throw new GenericRuntimeException( "cannot translate call " + call );
+            throw new GenericRuntimeException( "Cannot translate call " + call );
         }
         return implementor.implement( this, call, nullAs );
     }

plugins/cypher-language/src/main/java/org/polypheny/db/cypher/cypher2alg/CypherToAlgConverter.java

@@ -159,15 +159,13 @@ private void convertQuery( CypherNode node, CypherContext context ) {
         switch ( node.getCypherKind() ) {
             case SINGLE:
                 CypherSingleQuery query = (CypherSingleQuery) node;
-
                 for ( CypherClause clause : query.getClauses() ) {
                     convertClauses( clause, context );
                 }
-
                 break;
             case PERIODIC_COMMIT:
             case UNION:
-                throw new UnsupportedOperationException();
+                throw new UnsupportedOperationException( "Unsupported cypher operation: " + node.getCypherKind() );
         }
     }
 
@@ -201,9 +199,8 @@ private void convertClauses( CypherClause clause, CypherContext context ) {
                 convertRemove( (CypherRemove) clause, context );
                 break;
             default:
-                throw new UnsupportedOperationException();
+                throw new UnsupportedOperationException( "Unsupported cypher clause: " + clause.getCypherKind() );
         }
-
     }
 
 

plugins/cypher-language/src/main/java/org/polypheny/db/cypher/expression/CypherExpression.java

@@ -83,7 +83,7 @@ public Pair<PolyString, RexNode> getRex( CypherContext context, RexType type ) {
             case ANY -> OperatorName.CYPHER_ANY_MATCH;
             case NONE -> OperatorName.CYPHER_NONE_MATCH;
             case SINGLE -> OperatorName.CYPHER_SINGLE_MATCH;
-            default -> throw new UnsupportedOperationException();
+            default -> throw new UnsupportedOperationException( "Unsupported cypher expression: " + this.type );
         };
 
         //  ANY ( Variable IN Expression(list) Where? )

plugins/cypher-language/src/main/java/org/polypheny/db/cypher/expression/CypherFunctionInvocation.java

@@ -43,7 +43,7 @@ public CypherFunctionInvocation( ParserPos beforePos, ParserPos namePos, List<St
         if ( operatorNames.contains( image.toUpperCase( Locale.ROOT ) ) ) {
             this.op = OperatorName.valueOf( image.toUpperCase( Locale.ROOT ) );
         } else {
-            throw new GenericRuntimeException( "Used function is not supported!" );
+            throw new GenericRuntimeException( "Unsupported cypher function: " + image.toUpperCase( Locale.ROOT ) );
         }
         this.distinct = distinct;
         this.arguments = arguments;

plugins/cypher-language/src/main/java/org/polypheny/db/cypher/expression/CypherGate.java

@@ -63,7 +63,7 @@ public Pair<PolyString, RexNode> getRex( CypherContext context, RexType type ) {
                 operatorName = OperatorName.AND;
                 break;
             case XOR:
-                throw new UnsupportedOperationException();
+                throw new UnsupportedOperationException( "Unsupported cypher operator: " + gate );
             case NOT:
                 return handleSingular( context, type, OperatorName.NOT );
         }

plugins/cypher-language/src/main/java/org/polypheny/db/cypher/expression/CypherVariable.java

@@ -81,7 +81,7 @@ public Pair<PolyString, RexNode> getRex( CypherContext context, RexType type ) {
             }
         }
 
-        throw new GenericRuntimeException( "The used variable is not known." );
+        throw new GenericRuntimeException( "Unknown variable: " + name );
     }