kiln upload-release fails when given a compiled release

Authored-by: Matt Royal <mroyal@pivotal.io>

[#171270560] kiln upload-release fails when given a compiled release

Author: matt-royal

commands/upload_release.go

@@ -66,6 +66,9 @@ func (command UploadRelease) Execute(args []string) error {
 	}
 
 	manifest := part.Metadata.(builder.ReleaseManifest)
+	if manifest.StemcellOS != "" {
+		return fmt.Errorf("cannot upload compiled release %q - only uncompiled releases are allowed", command.Options.LocalPath)
+	}
 
 	requirement := release.Requirement{Name: manifest.Name, Version: manifest.Version}
 	_, found, err := releaseUploader.GetMatchedRelease(requirement)

commands/upload_release_test.go

@@ -98,6 +98,27 @@ var _ = Describe("UploadRelease", func() {
 					Expect(releaseUploader.UploadReleaseCallCount()).To(Equal(0))
 				})
 			})
+
+			When("the release tarball is compiled", func() {
+				BeforeEach(func() {
+					_, err := test_helpers.WriteTarballWithFile("banana-release.tgz", "release.MF", `
+name: banana
+version: 1.2.3
+compiled_packages:
+- stemcell: plan9/42
+`, fs)
+					Expect(err).NotTo(HaveOccurred())
+				})
+
+				It("errors and does not upload", func() {
+					err := uploadRelease.Execute([]string{
+						"--local-path", "banana-release.tgz",
+						"--upload-target-id", "orange-bucket",
+					})
+					Expect(err).To(MatchError(ContainSubstring("compiled release")))
+					Expect(releaseUploader.UploadReleaseCallCount()).To(Equal(0))
+				})
+			})
 		})
 
 		When("the release tarball is invalid", func() {