ci: Fix performance workflow dogfood build failures and harden analyzer summary parsing (#1120)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bcollamore <57269455+bcollamore@users.noreply.github.com>

Author: Copilot

.github/workflows/performance.yml

@@ -65,6 +65,7 @@ jobs:
           dotnet_diagnostic.IDE0290.severity = none
           dotnet_diagnostic.IDE0300.severity = none
           dotnet_diagnostic.IDE0301.severity = none
+          dotnet_diagnostic.IDE0303.severity = none
           dotnet_diagnostic.IDE0305.severity = none
           dotnet_diagnostic.PH2006.severity = none
           dotnet_diagnostic.PH2015.severity = none
@@ -113,4 +114,3 @@ jobs:
           ./Philips.CodeAnalysis.AnalyzerPerformance/bin/Release/net8.0/Philips.CodeAnalysis.AnalyzerPerformance msbuild.binlog Philips.CodeAnalysis >> PerformanceSummary.txt
           cat ./PerformanceSummary.txt
           cat ./PerformanceSummary.txt >> $GITHUB_STEP_SUMMARY
-

Philips.CodeAnalysis.Common/AnalyzerPerformanceRecord.cs

@@ -10,10 +10,29 @@ public sealed class AnalyzerPerformanceRecord : IComparable<AnalyzerPerformanceR
 	{
 		public static AnalyzerPerformanceRecord TryParse(string name)
 		{
-			var analyzerAndId = name.Split(' ');
-			var id = analyzerAndId[1].Substring(1, analyzerAndId[1].Length - 2);
+			if (string.IsNullOrWhiteSpace(name))
+			{
+				return null;
+			}
+
+			var analyzerAndId = name.Split((char[])null, StringSplitOptions.RemoveEmptyEntries);
+			if (analyzerAndId.Length < 4)
+			{
+				return null;
+			}
+
+			var idPart = analyzerAndId[1];
+			if (idPart.Length < 2 || idPart[0] != '"' || idPart[idPart.Length - 1] != '"')
+			{
+				return null;
+			}
+			var id = idPart.Substring(1, idPart.Length - 2);
 
 			var analyzerParts = analyzerAndId[0].Split('.');
+			if (analyzerParts.Length < 3)
+			{
+				return null;
+			}
 			var package = analyzerParts[2];
 			var analyzer = analyzerParts[analyzerParts.Length - 1];
 

Philips.CodeAnalysis.Test/Common/AnalyzerPerformanceRecordTest.cs

@@ -47,6 +47,20 @@ public void ParsedIncorrectly()
 			Assert.IsNull(actual);
 		}
 
+		[TestMethod]
+		[TestCategory(TestDefinitions.UnitTests)]
+		public void ParsedUnexpectedFormat()
+		{
+			// Arrange
+			const string testName = "Compiler diagnostics";
+
+			// Act
+			var actual = AnalyzerPerformanceRecord.TryParse(testName);
+
+			// Assert
+			Assert.IsNull(actual);
+		}
+
 		[TestMethod]
 		[TestCategory(TestDefinitions.UnitTests)]
 		public void SortsLargestTimeFirst()