PMM-14858 Skip built-in ClickHouse scrape for external instances#5369
Open
4nte wants to merge 13 commits into
Open
PMM-14858 Skip built-in ClickHouse scrape for external instances#53694nte wants to merge 13 commits into
4nte wants to merge 13 commits into
Conversation
4nte
requested review from
JiriCtvrtka and
maxkondr
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #5369 +/- ##
==========================================
+ Coverage 43.18% 43.24% +0.05%
==========================================
Files 413 413
Lines 42253 42297 +44
==========================================
+ Hits 18247 18290 +43
+ Misses 22140 22139 -1
- Partials 1866 1868 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
maxkondr
reviewed
May 18, 2026
Co-authored-by: Maxim Kondratenko <maxim.kondratenko@percona.com>
maxkondr
reviewed
May 20, 2026
maxkondr
approved these changes
May 21, 2026
ademidoff
approved these changes
May 21, 2026
JiriCtvrtka
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14858
Feature build
PMM kept scraping
127.0.0.1:9363even when an external ClickHouse was configured.Introduced new
ClickHouseParamsmodel struct that validates and facilitates CH parameters.ClickHouse scraping is now skipped when any of the following are true:
PMM_DISABLE_BUILTIN_CLICKHOUSEis set. (new)PMM_CLICKHOUSE_ADDRpoints to an external host.