`Receiver<Monitor>::check_payment` needs rename

[DanGould]

Which crate is this issue for?

payjoin

Motivation

not checking for a payment, checking for transaction broadcast. Payment != detected != settlement. IMO "payment" is best reserved for lightning. If this is looking for the txid of the

Possible solution

candidates for the rename include

• check_for_counterparty_broadcast
• detect_session_transaction
• watch_for_transaction

I'd look at bitcoin core and other places for naming inspiration. This is a matter of taste where I've been expressing settlement ~= payment everywhere it feels important to be consistent. And this function doesn't quite check for confirmed settlement afaiu. It needs to be made clear

This is for payjoin but will knock onto payjoin-ffi. If this can be done before 1.0, great. If not, we'll have to #[deprecate]

Useful Skills

No response

Guidance for new contributors

No response

[bnKabeer]

lemme give it a try

[spacebear21]

I like the check_for_counterparty_broadcast direction but "counterparty" is vaguely lightning-coded as well, I think we could simplify it to simply check_for_broadcast.