sha1/md5: fix exception safety, remove copy, and own exception message

Author: Easton97-Jens

build/win32/conanfile.txt

@@ -1,13 +1,13 @@
 [requires]
 yajl/2.1.0
-pcre2/10.42
-libxml2/2.12.6
+pcre2/10.47
+libxml2/2.15.3
 lua/5.4.6
-libcurl/8.6.0
-lmdb/0.9.31
-libmaxminddb/1.9.1
-dirent/1.24
-poco/1.13.3
+libcurl/8.19.0
+lmdb/0.9.35
+libmaxminddb/1.13.3
+dirent/1.26
+poco/1.15.2
 
 [generators]
 CMakeDeps

src/utils/string.h

@@ -249,9 +249,9 @@ inline std::string string_to_hex(const std::byte *input, size_t size) {
     char *d = a.data();
 
     for (size_t i = 0; i < size; ++i) {
-        const unsigned char c = std::to_integer<unsigned char>(input[i]);
-        *d++ = lut[c >> 4];
-        *d++ = lut[c & 15];
+        const std::byte b = input[i];
+        *d++ = lut[std::to_integer<unsigned>(b >> 4)];
+        *d++ = lut[std::to_integer<unsigned>(b & std::byte{0x0F})];
     }
 
     return a;