Skip to content

Commit 0a45b37

Browse files
Merge pull request #39 from Easton97-Jens/codex/fix-sonarqube-warnings-in-sha1.h
Remove reinterpret_casts in src/utils/sha1.h; use safer static_cast via void*
2 parents ed0202d + ea9c775 commit 0a45b37

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

src/utils/sha1.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,16 @@ class DigestImpl {
6060
}
6161

6262
if (const auto ret = mbedtls_md(mdInfo,
63-
reinterpret_cast<const unsigned char *>(input.data()),
63+
static_cast<const unsigned char *>(
64+
static_cast<const void *>(input.data())),
6465
input.size(), digest.data()); ret != 0) {
6566
return convertOp(std::string_view());
6667
}
6768

6869
// mbedtls uses unsigned char buffers, while string_view expects char.
69-
return convertOp(std::string_view(
70-
reinterpret_cast<const char *>(digest.data()), DigestSize));
70+
const auto *digestChars = static_cast<const char *>(
71+
static_cast<const void *>(digest.data()));
72+
return convertOp(std::string_view(digestChars, DigestSize));
7173
}
7274
};
7375

0 commit comments

Comments
 (0)