Merge pull request #10 from ovanschie/analysis-8LRJEn

Apply fixes from StyleCI

Author: ovanschie

app/code/community/Ovs/Magefaker/Block/Adminhtml/Faker/Edit.php

@@ -1,46 +1,49 @@
 <?php
 
 /**
- * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit
+ * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit.
  */
-class Ovs_Magefaker_Block_Adminhtml_Faker_Edit extends Mage_Adminhtml_Block_Widget_Form_Container {
-
+class Ovs_Magefaker_Block_Adminhtml_Faker_Edit extends Mage_Adminhtml_Block_Widget_Form_Container
+{
     /**
-     * Set basic config
+     * Set basic config.
      */
-    public function __construct() {
+    public function __construct()
+    {
         parent::__construct();
 
-        $this->_objectId    = 'id';
-        $this->_blockGroup  = 'ovs_magefaker';
-        $this->_controller  = 'adminhtml_faker';
+        $this->_objectId = 'id';
+        $this->_blockGroup = 'ovs_magefaker';
+        $this->_controller = 'adminhtml_faker';
 
         $this->_removeButton('back');
         $this->_removeButton('reset');
         $this->_removeButton('save');
 
-        $this->_addButton('start', array(
-            'label' => $this->__('Start'),
+        $this->_addButton('start', [
+            'label'   => $this->__('Start'),
             'onclick' => 'editForm.submit();',
-            'class' => 'save',
-        ), -100);
+            'class'   => 'save',
+        ], -100);
     }
 
     /**
-     * Set header
+     * Set header.
      *
      * @return string
      */
-    public function getHeaderText() {
+    public function getHeaderText()
+    {
         return $this->__('MageFaker - Fake data generator');
     }
 
     /**
-     * Remove icon from header class
+     * Remove icon from header class.
      *
      * @return string
      */
-    public function getHeaderCssClass() {
-        return 'head-' . strtr($this->_controller, '_', '-');
+    public function getHeaderCssClass()
+    {
+        return 'head-'.strtr($this->_controller, '_', '-');
     }
-}
+}

app/code/community/Ovs/Magefaker/Block/Adminhtml/Faker/Edit/Form.php

@@ -1,10 +1,10 @@
 <?php
 
 /**
- * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit_Form
+ * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit_Form.
  */
-class Ovs_Magefaker_Block_Adminhtml_Faker_Edit_Form extends Mage_Adminhtml_Block_Widget_Form {
-
+class Ovs_Magefaker_Block_Adminhtml_Faker_Edit_Form extends Mage_Adminhtml_Block_Widget_Form
+{
     /**
      * @return Mage_Core_Block_Abstract
      */
@@ -14,25 +14,25 @@ protected function _prepareLayout()
     }
 
     /**
-     * create the form
+     * create the form.
      *
-     * @return Mage_Adminhtml_Block_Widget_Form
      * @throws Exception
+     *
+     * @return Mage_Adminhtml_Block_Widget_Form
      */
     protected function _prepareForm()
     {
         // edit form
-        $edit_form = new Varien_Data_Form(array(
-            'id'        => 'edit_form',
-            'action'    => $this->getUrl('*/*/save', array('id' => $this->getRequest()->getParam('id'))),
-            'method'    => 'post',
-            'enctype'   => 'multipart/form-data'
-        ));
+        $edit_form = new Varien_Data_Form([
+            'id'      => 'edit_form',
+            'action'  => $this->getUrl('*/*/save', ['id' => $this->getRequest()->getParam('id')]),
+            'method'  => 'post',
+            'enctype' => 'multipart/form-data',
+        ]);
 
         $edit_form->setUseContainer(true);
         $this->setForm($edit_form);
 
         return parent::_prepareForm();
     }
-
-}
+}

app/code/community/Ovs/Magefaker/Block/Adminhtml/Faker/Edit/Tabs.php

@@ -1,13 +1,15 @@
 <?php
 
 /**
- * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit_Tabs
+ * Class Ovs_MageFaker_Block_Adminhtml_Faker_Edit_Tabs.
  */
-class Ovs_Magefaker_Block_Adminhtml_Faker_Edit_Tabs extends Mage_Adminhtml_Block_Widget_Tabs{
+class Ovs_Magefaker_Block_Adminhtml_Faker_Edit_Tabs extends Mage_Adminhtml_Block_Widget_Tabs
+{
     /**
-     * config
+     * config.
      */
-    public function __construct(){
+    public function __construct()
+    {
         parent::__construct();
 
         $this->setId('faker_tabs');
@@ -16,16 +18,17 @@ public function __construct(){
     }
 
     /**
-     * Set the tabs
+     * Set the tabs.
      *
-     * @return Mage_Core_Block_Abstract
      * @throws Exception
+     *
+     * @return Mage_Core_Block_Abstract
      */
-    protected function _beforeToHtml() {
-
+    protected function _beforeToHtml()
+    {
         $this->addTab('adminhtml_tab_insert', 'ovs_magefaker/adminhtml_faker_edit_tabs_insert');
         $this->addTab('adminhtml_tab_remove', 'ovs_magefaker/adminhtml_faker_edit_tabs_remove');
 
         return parent::_beforeToHtml();
     }
-}
+}